Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #128182: Fix crash on kube manager's service-lb-controller after v1.31.0. #128236

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Automated cherry pick of #128182: Fix crash on kube manager's service-lb-controller after v1.31.0. #128236

merged 1 commit into from
Nov 12, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented Oct 21, 2024

Cherry pick of #128182 on release-1.31.

#128182: Fix crash on kube manager's service-lb-controller after v1.31.0.

For details on the cherry pick process, see the cherry pick requests page.

Fixes 1.31 regression that can crash kube-controller-manager's service-lb-controller loop

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Oct 21, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 21, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sttts October 21, 2024 16:55
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 21, 2024
@carlory
Copy link
Member Author

carlory commented Oct 21, 2024

/cc @aojea @thockin

@k8s-ci-robot k8s-ci-robot requested review from aojea and thockin October 21, 2024 16:56
@aojea
Copy link
Member

aojea commented Oct 21, 2024

it is better to squash it in one commit, I added the command on the CI to do it in the upstream PR , so it was merged as 442183a.

@carlory @aojea
Fix crash on kube manager's service-lb-controller after v1.31.0.
fb63fe6 
Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
@carlory carlory force-pushed the automated-cherry-pick-of-#128182-upstream-release-1.31 branch from a1e8c43 to fb63fe6 Compare October 22, 2024 02:20
@carlory
Copy link
Member Author

carlory commented Oct 22, 2024

@aojea done.

@BenTheElder
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 22, 2024
@aojea
Copy link
Member

aojea commented Oct 22, 2024

/lgtm
/approve

Thanks

/kind bug
/kind regression

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 22, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac86b372198404ccff03a273c933900578d07aa0

@aojea
Copy link
Member

aojea commented Nov 6, 2024

ping @kubernetes/release-managers

/assign @cheftako

@aojea aojea mentioned this pull request Nov 6, 2024
Closed
@aojea
Copy link
Member

aojea commented Nov 6, 2024

/assign @thockin

I think you have approval rights on those folders

@jeremyrickard
Copy link
Contributor

ping @kubernetes/release-managers

/assign @cheftako

I will review this once it's been approved!

thockin
thockin reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2024
@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, carlory, saschagrunert, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c9e75e7 into kubernetes:release-1.31 Nov 12, 2024
16 checks passed
This was referenced Nov 24, 2024
Open
Open
Open
@pohly pohly mentioned this pull request Nov 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@sttts sttts Awaiting requested review from sttts

@aojea aojea Awaiting requested review from aojea

Assignees

@cheftako cheftako

@thockin thockin

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
8 participants
@carlory @aojea @BenTheElder @k8s-ci-robot @jeremyrickard @saschagrunert @thockin @cheftako