Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macsko to SIG Scheduling reviewers #128127

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Add macsko to SIG Scheduling reviewers #128127

merged 1 commit into from
Oct 24, 2024
+1 −0

Conversation

macsko
Copy link
Member

@macsko macsko commented Oct 16, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Hi everyone, I would like to self-nominate to become a SIG Scheduling reviewer:

/sig scheduling

Which issue(s) this PR fixes:

Special notes for your reviewer:

Thank you all!

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 16, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 16, 2024
@macsko
Copy link
Member Author

macsko commented Oct 16, 2024

/cc @alculquicondor

@alculquicondor
Copy link
Member

Those are astonishing numbers!
I am more than happy to have you as a reviewer.
/lgtm

cc @kubernetes/sig-scheduling-approvers

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1c0fad9e0663c104a5e07932c6f834e5350b7d2f

@Huang-Wei
Copy link
Member

/lgtm

Welcome @macsko !

@sanposhiho
Copy link
Member

/lgtm

Thanks for the reviewing help so far, our development velocity has gotten speed up a looooot 😄

@kerthcet
Copy link
Member

/lgtm

Welcom aboard! cc @dims for OWNER approval.

@macsko
Copy link
Member Author

macsko commented Oct 22, 2024

@dims gently ping

@macsko
Copy link
Member Author

macsko commented Oct 23, 2024

/retest

@dims
Copy link
Member

dims commented Oct 24, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, macsko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 122fa7c into kubernetes:master Oct 24, 2024
13 of 14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dims dims Awaiting requested review from dims

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

@Huang-Wei Huang-Wei

@kerthcet kerthcet

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
7 participants
@macsko @k8s-ci-robot @alculquicondor @Huang-Wei @sanposhiho @kerthcet @dims