Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage fsquota monitoring pod should be user namespaced #128074

Merged
merged 1 commit into from
Oct 17, 2024
Merged

storage fsquota monitoring pod should be user namespaced #128074

merged 1 commit into from
Oct 17, 2024
+1 −0

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Oct 15, 2024

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #128042

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 15, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Oct 15, 2024

/test pull-kubernetes-node-crio-cgrpv2-userns-e2e-serial

@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 15, 2024
@pacoxu pacoxu force-pushed the fix-quota_lsci-e2e branch from a0b58c4 to 376cde8 Compare October 15, 2024 03:14
@pacoxu
Copy link
Member Author

pacoxu commented Oct 15, 2024

/test pull-kubernetes-node-crio-cgrpv2-userns-e2e-serial

@pacoxu pacoxu marked this pull request as ready for review October 15, 2024 05:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Oct 15, 2024

/cc @haircommander @kannon92

@pacoxu pacoxu mentioned this pull request Oct 15, 2024
Open
@pacoxu pacoxu force-pushed the fix-quota_lsci-e2e branch from 376cde8 to 386f495 Compare October 15, 2024 06:43
@haircommander
Copy link
Contributor

/lgtm

so true! good catch

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b89851e79a4b82be89e9b471c69c80071991d32

@kannon92
Copy link
Contributor

/assign @SergeyKanzhelev @mrunalp

@kannon92
Copy link
Contributor

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1b20b08 into kubernetes:master Oct 17, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@kannon92 kannon92 Awaiting requested review from kannon92

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@mrunalp mrunalp

@haircommander haircommander

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Status: Done
Milestone
v1.32
6 participants
@pacoxu @k8s-ci-robot @haircommander @kannon92 @mrunalp @SergeyKanzhelev