Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #127285: Update etcd from v3.5.15 to v3.5.16 #127283: Build etcd image of v3.5.16 #127953

Open
wants to merge 2 commits into
base: release-1.30
Choose a base branch
from
Open

Automated cherry pick of #127285: Update etcd from v3.5.15 to v3.5.16 #127283: Build etcd image of v3.5.16 #127953

wants to merge 2 commits into from

Conversation

bzsuni
Copy link
Contributor

@bzsuni bzsuni commented Oct 9, 2024 •
edited
Loading

Cherry pick of #127285 #127283 on release-1.30.

#127285: Update etcd from v3.5.15 to v3.5.16
#127283: Build etcd image of v3.5.16

For details on the cherry pick process, see the cherry pick requests page.

none

@k8s-ci-robot
Copy link
Contributor

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process.

If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm area/provider/gcp Issues or PRs related to gcp provider labels Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/test do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 9, 2024
@Jefftree
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 10, 2024
@aaron-prindle aaron-prindle mentioned this pull request Oct 10, 2024
Open
@bzsuni bzsuni force-pushed the automated-cherry-pick-of-#127285-#127283-upstream-release-1.30 branch from b83c9a6 to 79d5b24 Compare October 11, 2024 01:21
@pacoxu
Copy link
Member

pacoxu commented Oct 11, 2024

/lgtm
/kind cleanup
/cc @serathius
/assign @dims

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e27b91910cc1d596378718e4252b3e0bd1733b41

@pacoxu
Copy link
Member

pacoxu commented Oct 11, 2024

/test pull-kubernetes-unit-go-compatibility

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 11, 2024
@bzsuni
Copy link
Contributor Author

bzsuni commented Oct 11, 2024

/test pull-kubernetes-unit-go-compatibility

@dims
Copy link
Member

dims commented Oct 13, 2024

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2024
@pacoxu
Copy link
Member

pacoxu commented Oct 14, 2024

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team October 14, 2024 01:04
@bzsuni
Copy link
Contributor Author

bzsuni commented Oct 14, 2024

/assign saschagrunert

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2024
bzsuni added 2 commits November 7, 2024 09:43
@bzsuni
Update etcd from v3.5.15 to v3.5.16
745b9ad 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@bzsuni
Build etcd image v3.5.16
7712526 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@bzsuni bzsuni force-pushed the automated-cherry-pick-of-#127285-#127283-upstream-release-1.30 branch from 79d5b24 to 7712526 Compare November 7, 2024 09:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@bzsuni
Copy link
Contributor Author

bzsuni commented Nov 7, 2024

/test pull-kubernetes-integration-go-compatibility

@bzsuni
Copy link
Contributor Author

bzsuni commented Nov 8, 2024

@dims I have rebased this pr. For lgtm please

@dims
Copy link
Member

dims commented Nov 8, 2024

/approve
/assign @serathius

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bzsuni, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@humblec
Copy link
Contributor

humblec commented Nov 13, 2024

lgtm. thanks

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mleneveut
Copy link

@bzsuni seems to need another rebase. The 1.30.8 release is still requesting ETCD 3.5.15, annoying for upgrades from 1.29.11 to 1.30.8 :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako Awaiting requested review from cheftako

@jpbetz jpbetz Awaiting requested review from jpbetz

@serathius serathius Awaiting requested review from serathius

@dims dims Awaiting requested review from dims

@pacoxu pacoxu Awaiting requested review from pacoxu

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@dims dims

@saschagrunert saschagrunert

@pacoxu pacoxu

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
9 participants
@bzsuni @k8s-ci-robot @Jefftree @pacoxu @dims @humblec @mleneveut @saschagrunert @serathius