Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental client for horizontal pod autoscaler. #12792

Merged
merged 1 commit into from
Aug 20, 2015

Conversation

jszczepkowski
Copy link
Contributor

Implementation of experimental client for horizontal pod autoscaler. Placeholder implementation for controller for horizontal pod autoscaler.

@jszczepkowski jszczepkowski added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Aug 17, 2015
@k8s-bot
Copy link

k8s-bot commented Aug 17, 2015

GCE e2e build/test passed for commit fe7022638ed65b39992531392f91c21aff93f418.

@jszczepkowski jszczepkowski assigned davidopp and unassigned mwielgus Aug 17, 2015
)

// Returns the appropriate path for the given prefix (watch, proxy, redirect, etc), resource, namespace and name.
// For ex, this is of the form:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spell out "example"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jszczepkowski
Copy link
Contributor Author

@davidopp All comments are applied, PTAL.

@k8s-bot
Copy link

k8s-bot commented Aug 18, 2015

GCE e2e build/test passed for commit a63a432b783ebb13478e812969858ab88a35c0a0.

Implementation of experimental client for horizontal pod autoscaler. Placeholder implementation for controller for horizontal pod autoscaler.
@k8s-bot
Copy link

k8s-bot commented Aug 19, 2015

GCE e2e build/test passed for commit 8def28afb8d7dcb974a0991712c135cf6f775587.

@k8s-bot
Copy link

k8s-bot commented Aug 19, 2015

GCE e2e build/test passed for commit f2e15fd.

@davidopp
Copy link
Member

LGTM

@davidopp davidopp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2015
wojtek-t added a commit that referenced this pull request Aug 20, 2015
Experimental client for horizontal pod autoscaler.
@wojtek-t wojtek-t merged commit 3b3a706 into kubernetes:master Aug 20, 2015
@jszczepkowski
Copy link
Contributor Author

Part of #12087.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants