Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/config: assing system:apiserver user to system:authenticated group #127902

Merged
merged 1 commit into from
Oct 7, 2024
Merged

server/config: assing system:apiserver user to system:authenticated group #127902

merged 1 commit into from
Oct 7, 2024

Conversation

p0lyn0mial
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 7, 2024
@p0lyn0mial
Copy link
Contributor Author

/assign @deads2k

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 7, 2024
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 7, 2024
@deads2k
Copy link
Contributor

deads2k commented Oct 7, 2024

This doesn't change the level of access. This does correct the user.Info to ensure that things like audit log rules apply as users would expect. This is a good idea to backport.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d9d1aa159c7f87874b3ccd6fda6e7659e68c5b8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8155327 into kubernetes:master Oct 7, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 7, 2024
@p0lyn0mial p0lyn0mial mentioned this pull request Oct 8, 2024
Merged
@Jefftree
Copy link
Member

Jefftree commented Oct 8, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 8, 2024
@jeremyrickard
Copy link
Contributor

@p0lyn0mial does this only apply to 1.31?

@p0lyn0mial
Copy link
Contributor Author

@p0lyn0mial does this only apply to 1.31?

@jeremyrickard no, it doesn't. I think it applies to the previous versions as well.

@xmudrii
Copy link
Member

xmudrii commented Oct 23, 2024

@p0lyn0mial Can you please create cherry-picks for other affected versions and link those cherry-picks here? Thanks!

@p0lyn0mial
Copy link
Contributor Author

@p0lyn0mial Can you please create cherry-picks for other affected versions and link those cherry-picks here? Thanks!

@xmudrii sure, how far back do we want to go? All the way to 1.29?

@xmudrii
Copy link
Member

xmudrii commented Oct 24, 2024

All the way to 1.29?

If 1.29 is affected, yes please!

This was referenced Oct 30, 2024
Merged
Merged
@p0lyn0mial
Copy link
Contributor Author

If 1.29 is affected, yes please!

@xmudrii done:

#128445
#128446

@xmudrii
Copy link
Member

xmudrii commented Oct 31, 2024

@p0lyn0mial Approved, thanks a lot!

k8s-ci-robot added a commit that referenced this pull request Oct 31, 2024
@k8s-ci-robot
Merge pull request #128446 from p0lyn0mial/automated-cherry-pick-of-#…
f2b2251 
…127902-upstream-release-1.29

Automated cherry pick of #127902: server/config: assing system:apiserver user to system:authenticated group
k8s-ci-robot added a commit that referenced this pull request Oct 31, 2024
@k8s-ci-robot
Merge pull request #128445 from p0lyn0mial/automated-cherry-pick-of-#…
be00148 
…127902-upstream-release-1.30

Automated cherry pick of #127902: server/config: assing system:apiserver user to system:authenticated group
k8s-ci-robot added a commit that referenced this pull request Nov 1, 2024
@k8s-ci-robot
Merge pull request #127928 from p0lyn0mial/automated-cherry-pick-of-#…
6d1bcd7 
…127902-upstream-release-1.31

Automated cherry pick of #127902: server/config: assing system:apiserver user to system:authenticated group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj Awaiting requested review from enj

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
6 participants
@p0lyn0mial @deads2k @k8s-ci-robot @Jefftree @jeremyrickard @xmudrii