Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for VolumeRestriction in requeueing scenarios #127892

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add integration test for VolumeRestriction in requeueing scenarios #127892

merged 1 commit into from
Oct 11, 2024
+67 −0

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Oct 6, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add integration test for VolumeRestriction in requeueing scenarios

Which issue(s) this PR fixes:

Part of #122305

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 6, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 6, 2024
@k8s-ci-robot k8s-ci-robot requested review from AxeZhan and damemi October 6, 2024 12:47
@AxeZhan
Copy link
Member

AxeZhan commented Oct 6, 2024

Maybe we can also add cases for not requeued scenario?

@utam0k utam0k force-pushed the test-qhint-volume-restriction branch from 024deae to 2185f74 Compare October 7, 2024 05:26
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2024
@utam0k
Copy link
Member Author

utam0k commented Oct 7, 2024

Maybe we can also add cases for not requeued scenario?

Added the simple scenario for not requeued.

@AxeZhan
Copy link
Member

AxeZhan commented Oct 7, 2024

/lgtm
For not requeued case, we may need a follow-up in #127607

/cc @sanposhiho

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6e48d190e71da92a75e5ae544d6b8ad13650858c

@utam0k utam0k force-pushed the test-qhint-volume-restriction branch from 2185f74 to 58ed769 Compare October 7, 2024 11:37
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 7, 2024
@k8s-ci-robot k8s-ci-robot requested a review from AxeZhan October 7, 2024 11:37
@utam0k utam0k requested a review from sanposhiho October 7, 2024 11:38
@AxeZhan
Copy link
Member

AxeZhan commented Oct 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8ca99e6961bf125c6bf95670520ad45a91c77bc8

@sanposhiho
Copy link
Member

sanposhiho commented Oct 9, 2024 •
edited
Loading

LGTM, but please rebase; #127607 is now merged and triggerFn got a small change.

@utam0k utam0k force-pushed the test-qhint-volume-restriction branch from 58ed769 to 60c29c3 Compare October 9, 2024 23:31
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2024
@utam0k
Copy link
Member Author

utam0k commented Oct 9, 2024

LGTM, but please rebase; #127607 is now merged and triggerFn got a small change.

Sure! Done.

sanposhiho
sanposhiho approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0bd2148e4e5d9a7ff43730bea36790da4ff97899

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho, utam0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9ffc095 into kubernetes:master Oct 11, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 11, 2024
@utam0k utam0k mentioned this pull request Oct 28, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho approved these changes

@damemi damemi Awaiting requested review from damemi

@AxeZhan AxeZhan Awaiting requested review from AxeZhan

Assignees

@sanposhiho sanposhiho

@AxeZhan AxeZhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
4 participants
@utam0k @k8s-ci-robot @AxeZhan @sanposhiho