Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(leaderelection): nil check in OnStoppedLeading func #127834

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(leaderelection): nil check in OnStoppedLeading func #127834

merged 1 commit into from
Oct 3, 2024

Conversation

googs1025
Copy link
Member

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

  • fix ci flake
    Fix flake first, and then improve the mechanism after thoroughly discussing a better solution.

Which issue(s) this PR fixes:

Fixes # #127737 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2024
@googs1025
Copy link
Member Author

googs1025 commented Oct 3, 2024 •
edited
Loading

/assign @aojea @liggitt
/PTAL
@aojea @liggitt

@googs1025
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@liggitt
Copy link
Member

liggitt commented Oct 3, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5a460b88edaa1a5063a86eabb063e258d1367a18

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: googs1025, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2024
@aojea
Copy link
Member

aojea commented Oct 3, 2024

Kubernetes e2e suite: [It] [sig-api-machinery] ResourceQuota should verify ResourceQuota with terminating scopes. [Conformance] expand_more

/test pull-kubernetes-e2e-gce

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 3, 2024
@aojea
Copy link
Member

aojea commented Oct 3, 2024

The bot will not pick it because the format is not correct

Fixes # #127737 (comment)

once it merges remember to close the associated issue

Thanks

@googs1025
Copy link
Member Author

The bot will not pick it because the format is not correct

Fixes # #127737 (comment)

once it merges remember to close the associated issue

Thanks

ok got it😄

@k8s-ci-robot k8s-ci-robot merged commit fa3ff38 into kubernetes:master Oct 3, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 3, 2024
@aojea aojea mentioned this pull request Oct 3, 2024
Closed
@googs1025 googs1025 mentioned this pull request Oct 7, 2024
Closed
@Jefftree
Copy link
Member

Should we backport this to 1.31?

@googs1025 googs1025 mentioned this pull request Oct 25, 2024
Merged
@Jefftree Jefftree mentioned this pull request Nov 1, 2024
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 12, 2024
@k8s-ci-robot
Merge pull request #128340 from googs1025/automated-cherry-pick-of-#1…
11d2b4d 
…27834-upstream-release-1.31

Automated cherry pick of #127834: fix(leaderelection): nil check in OnStoppedLeading func
This was referenced Nov 24, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@liggitt liggitt

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
6 participants
@googs1025 @liggitt @k8s-ci-robot @aojea @fedebongio @Jefftree