Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4358: Promote Custom Resource Field Selectors to GA #127673

Merged
merged 3 commits into from
Oct 1, 2024
Merged

KEP-4358: Promote Custom Resource Field Selectors to GA #127673

merged 3 commits into from
Oct 1, 2024

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Sep 26, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

kubernetes/enhancements#4358

Special notes for your reviewer:

Does this PR introduce a user-facing change?

-->

Promoted `CustomResourceFieldSelectors` to stable; the feature is enabled by default. `--feature-gates=CustomResourceFieldSelectors=true` not needed on kube-apiserver binaries and will be removed in a future release.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 26, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Sep 26, 2024 •
edited
Loading

/hold
Until #127672 merges. (this PR is stacked on that PR so this PR can be tested)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
@jpbetz jpbetz force-pushed the crd-field-selector-ga branch from 4b5abf4 to c0f4577 Compare September 27, 2024 00:12
This was referenced Sep 27, 2024
Open
Merged
@jpbetz jpbetz force-pushed the crd-field-selector-ga branch from c0f4577 to ae9b2bf Compare September 27, 2024 13:53
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2024
@jpbetz jpbetz force-pushed the crd-field-selector-ga branch 2 times, most recently from 3df78e7 to f126915 Compare September 27, 2024 18:57
@jpbetz
Copy link
Contributor Author

jpbetz commented Sep 27, 2024

/hold
Until #127643, then I'll drop the second commit on this and it should be ready.

@jpbetz jpbetz force-pushed the crd-field-selector-ga branch from f126915 to 74382b8 Compare September 27, 2024 22:59
@jpbetz
Copy link
Contributor Author

jpbetz commented Sep 27, 2024

rebased
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@jpbetz jpbetz force-pushed the crd-field-selector-ga branch from 74382b8 to c62f161 Compare September 28, 2024 00:54
jpbetz
jpbetz commented Sep 28, 2024
View reviewed changes
staging/src/k8s.io/apiextensions-apiserver/pkg/cmd/server/testing/testserver.go
Comment on lines +127 to +131

// Configure the effective version.
effectiveVersion := utilversion.DefaultKubeEffectiveVersion()
effectiveVersion.SetEmulationVersion(featureGate.EmulationVersion())

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jefftree does this looks right? I still needed it after #127643 merged and I rebased to master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is for apiextension testserver which I missed in #127643. Is the CI passing at the moment? I think we need will need to change it to pass binaryversion and emulatedversion as testserver options like in #127643. I'll look a bit more into it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG. Do you want to hold this for that fix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait actually looking at this again I like this approach more than #127643 since we don't need to explicitly pass in the parameters and can infer it from the feature gate settings. LGTM

@jpbetz jpbetz force-pushed the crd-field-selector-ga branch from c62f161 to 6a4a856 Compare October 1, 2024 15:52
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2024
@jpbetz jpbetz force-pushed the crd-field-selector-ga branch from 6a4a856 to de8a8e1 Compare October 1, 2024 15:58
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2024
@Jefftree
Copy link
Member

Jefftree commented Oct 1, 2024

/lgtm
/approve
/hold (in case you want additional eyes)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7642c4ff17b540d26606fa473c1f9955318db331

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 1, 2024

/retest

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 1, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 523a2b6 into kubernetes:master Oct 1, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 1, 2024
@seans3
Copy link
Contributor

seans3 commented Oct 1, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 1, 2024
@mengjiao-liu mengjiao-liu mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefftree Jefftree Jefftree left review comments

@logicalhan logicalhan Awaiting requested review from logicalhan

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@Jefftree Jefftree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@jpbetz @k8s-triage-robot @Jefftree @k8s-ci-robot @seans3