Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: fix a bug where the RemoveMember function did not return the correct member list when the member to be removed did not exist #127650

Merged
merged 1 commit into from
Sep 26, 2024
Merged

kubeadm: fix a bug where the RemoveMember function did not return the correct member list when the member to be removed did not exist #127650

merged 1 commit into from
Sep 26, 2024

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Sep 26, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

kubeadm: fix a bug where the RemoveMember function did not return the correct member list when the member to be removed did not exist

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

We don't actually use the member list returned by RemoveMember, just to print debug messages:

kubernetes/cmd/kubeadm/app/phases/etcd/local.go

Lines 129 to 133 in 9770283

members, err = etcdClient.RemoveMember(id)
if err != nil {
return err
}
klog.V(1).Infof("[etcd] Updated etcd member list: %v", members)

So the cherry-pick doesn't seem to make much sense.

Does this PR introduce a user-facing change?

kubeadm: fix wrong member list reported when removing an etcd member

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@SataQiu
kubeadm: fix a bug where the RemoveMember function did not return the…
2dc0d29 
… correct member list when the member to be removed did not exist
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm labels Sep 26, 2024
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 26, 2024
neolit123
neolit123 reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

the unit tests might need to be improved in the future to catch problems like this. i believe etcd have a mock server/client that can be used. cc @my-git9 you might be interested.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 06df3b57c832596025db59dfe772c8b71f840b22

@k8s-ci-robot k8s-ci-robot merged commit 996e674 into kubernetes:master Sep 26, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 26, 2024
@neolit123
Copy link
Member

@SataQiu should this be part of the backports?

@pacoxu pacoxu mentioned this pull request Oct 9, 2024
Open
This was referenced Oct 9, 2024
Merged
Merged
Merged
@neolit123
Copy link
Member

/release-note-edit

kubeadm: fix wrong member list reported when removing an etcd member

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 9, 2024
@SataQiu SataQiu mentioned this pull request Oct 9, 2024
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 9, 2024
@k8s-ci-robot
Merge pull request #127960 from SataQiu/automated-cherry-pick-of-#127…
988235a 
…650-upstream-release-1.31

Automated cherry pick of #127650: kubeadm: fix a bug where the RemoveMember function did not return the correct member list when the member to be removed did not exist
k8s-ci-robot added a commit that referenced this pull request Oct 9, 2024
@k8s-ci-robot
Merge pull request #127962 from SataQiu/automated-cherry-pick-of-#127…
da4c316 
…650-upstream-release-1.29

Automated cherry pick of #127650: kubeadm: fix a bug where the RemoveMember function did not return the correct member list when the member to be removed did not exist
k8s-ci-robot added a commit that referenced this pull request Oct 9, 2024
@k8s-ci-robot
Merge pull request #127961 from SataQiu/automated-cherry-pick-of-#127…
065a97c 
…650-upstream-release-1.30

Automated cherry pick of #127650: kubeadm: fix a bug where the RemoveMember function did not return the correct member list when the member to be removed did not exist
k8s-ci-robot added a commit that referenced this pull request Oct 11, 2024
@k8s-ci-robot
Merge pull request #127963 from SataQiu/automated-cherry-pick-of-#127…
30993e2 
…650-upstream-release-1.28

Automated cherry pick of #127650: kubeadm: fix a bug where the RemoveMember function did not
This was referenced Oct 27, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@carlory carlory Awaiting requested review from carlory

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@SataQiu @k8s-ci-robot @neolit123