Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build etcd image of v3.5.16 #127283

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Build etcd image of v3.5.16 #127283

merged 1 commit into from
Sep 13, 2024

Conversation

bzsuni
Copy link
Contributor

@bzsuni bzsuni commented Sep 11, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

etcd is now released in v3.5.16

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 11, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 11, 2024
@bzsuni bzsuni mentioned this pull request Sep 11, 2024
Merged
@bzsuni
Build etcd image v3.5.16
7008652 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@bzsuni bzsuni force-pushed the bz/etcd/image/build/v3.5.16 branch from c6ca64b to 7008652 Compare September 11, 2024 03:31
@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 238686b80211adbb1f5e9bc88a86f0cdfe8e57d9

pacoxu
pacoxu reviewed Sep 12, 2024
View reviewed changes
cluster/images/etcd/migrate/options.go
@@ -28,7 +28,7 @@ import (
)

var (
supportedEtcdVersions = []string{"3.4.18", "3.5.15"}
supportedEtcdVersions = []string{"3.4.18", "3.5.16"}
Copy link
Member

@pacoxu pacoxu Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to v3.4.34?

https://github.com/kubernetes/kubernetes/pull/127283/files#diff-de315dbb88d6d341b1682ef2fb0798723139fb4202ac607a334fc301e9359ec7R18 should be update if we want to bump the 3.4.x here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @ahrtr @jpbetz

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to v3.4.34?

Yes, I think so.

  • It seems that nobody care about etcd 3.4.x obviously it isn't updated for a long time?
  • It's accepted to address it in a separate PR since this one is solely intended to bump the 3.5.x?

Copy link
Member

@pacoxu pacoxu Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that nobody care about etcd 3.4.x obviously it isn't updated for a long time?

A quick check, we didn't build 3.4.18 even. The latest 3.4.x in kubernetes/k8s.io is 3.4.13-3.
https://github.com/kubernetes/k8s.io/blob/ca7a917e59f19fbdab73b07440bf7d843e61126d/registry.k8s.io/images/k8s-staging-etcd/images.yaml#L6

    "sha256:528ff5e3c80ca0d58d1ab15dc329dc300f9c3fefaffa4c822ca2c389ce254644": ["3.4.13-3"]

It's accepted to address it in a separate PR since this one is solely intended to bump the 3.5.x?

Agree.

@pacoxu
Copy link
Member

pacoxu commented Sep 12, 2024

/lgtm
/assign @justaugustus @serathius

@seans3
Copy link
Contributor

seans3 commented Sep 12, 2024

/SIG etcd

@seans3
Copy link
Contributor

seans3 commented Sep 12, 2024

/remove-sig api-machinery

This should be SIG etcd now.

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 12, 2024
@aaron-prindle aaron-prindle mentioned this pull request Sep 12, 2024
Open
@ahrtr
Copy link
Member

ahrtr commented Sep 13, 2024

/lgtm
/approve

@dims
Copy link
Member

dims commented Sep 13, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, bzsuni, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 20dd888 into kubernetes:master Sep 13, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 13, 2024
This was referenced Oct 9, 2024
Merged
Open
Open
Closed
k8s-ci-robot added a commit that referenced this pull request Nov 12, 2024
@k8s-ci-robot
Merge pull request #127951 from bzsuni/automated-cherry-pick-of-#127285-
c5ab4e3 
#127283-upstream-release-1.29

Automated cherry pick of #127285: Update etcd from v3.5.15 to v3.5.16
#127283: Build etcd image of v3.5.16
@adammw
Copy link

adammw commented Dec 2, 2024

Any takers for v3.5.17 ?

@bzsuni
Copy link
Contributor Author

bzsuni commented Dec 2, 2024

Any takers for v3.5.17 ?

Yes, I need to wait for the PR #128773 to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@liggitt liggitt Awaiting requested review from liggitt

@serathius serathius Awaiting requested review from serathius

@ahrtr ahrtr Awaiting requested review from ahrtr

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@justaugustus justaugustus

@pacoxu pacoxu

@serathius serathius

@ahrtr ahrtr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
9 participants
@bzsuni @k8s-ci-robot @serathius @pacoxu @seans3 @ahrtr @dims @adammw @justaugustus