kubeadm: remove deprecated upgrade flags for 1.32 #127123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
pacoxu
reviewed
Sep 5, 2024
| cmd.Flags().MarkDeprecated("controller-manager-manifest", "This flag is deprecated and will be removed in a future release.") | ||
| cmd.Flags().StringVar(&flags.schedulerManifestPath, "scheduler-manifest", defaultSchedulerManifestPath, "path to scheduler manifest") | ||
| cmd.Flags().MarkDeprecated("scheduler-manifest", "This flag is deprecated and will be removed in a future release.") | ||
| cmd.Flags().IntVarP(&flags.contextLines, "context-lines", "c", 3, "How many lines of context in the diff") |
There was a problem hiding this comment.
kubernetes/cmd/kubeadm/app/cmd/upgrade/diff.go
Lines 57 to 61 in bce499c
As the CI failure, those variables can be removed as well.
Overall LGTM.
There was a problem hiding this comment.
looks like i also removed context-lines which should not be done.
The flags for control-plane component manifest under 'upgrade diff' and the --feture-gates flag were deprecated and NOOP in 1.31 and can be removed in 1.32.
neolit123
force-pushed
the
1.32-remove-deprecated-upgrade-flags
branch
from
d16ddf4 to
730fd13
Compare
|
looking for LGTM |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a114ef93b170212a0ff3e2d313d94e9eb6f73dde
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The flags for control-plane component manifest under 'upgrade diff' and the --feture-gates flag were deprecated and NOOP in 1.31 and can be removed in 1.32.
Which issue(s) this PR fixes:
fixes kubernetes/kubeadm#3083
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: