Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement Pod smaller update events #127083

Merged
merged 1 commit into from
Sep 3, 2024
Merged

feat: implement Pod smaller update events #127083

merged 1 commit into from
Sep 3, 2024
+84 −52

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Sep 3, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

implement new Pod smaller update events; UpdatePodSchedulingGatesEliminated and UpdatePodTolerations.
It's a continuous work from #122628, I intentionally didn't support those update events in #122628:

EDIT(2024/Jun/28): Actually even after this PR there are some remaining Pod/Update events, which are added in #122234. I'll deal with them as a follow up so that I don't make this PR even bigger from where has been reviewed so far.

and the motivation are:

  • We can reduce the number of events subscribed by the scheduler, thus reducing the amount of memory consumed for in-flight events.
  • We can clarify Pod update events before events go to the queue, instead of QHints. It should reduce the latency of QHints execution.

Which issue(s) this PR fixes:

Part of #120622

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Implement new cluster events UpdatePodSchedulingGatesEliminated and UpdatePodTolerations for scheduler plugins.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
sanposhiho
sanposhiho commented Sep 3, 2024
View reviewed changes
pkg/scheduler/scheduler_test.go
name: "plugins with default profile (queueingHint: enabled)",
plugins: schedulerapi.PluginSet{Enabled: defaults.PluginsV1.MultiPoint.Enabled},
want: map[framework.GVK]framework.ActionType{
framework.Pod: framework.Add | framework.UpdatePodLabel | framework.UpdatePodScaleDown | framework.UpdatePodTolerations | framework.UpdatePodSchedulingGatesEliminated | framework.Delete,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new test shows that we eliminated all Pod/Update events from in-tree plugins.

@k8s-ci-robot
Copy link
Contributor

@sanposhiho: GitHub didn't allow me to request PR reviews from the following users: macs.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Macs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sanposhiho
Copy link
Member Author

/cc @macsko

@k8s-ci-robot k8s-ci-robot requested a review from macsko September 3, 2024 07:31
@macsko
Copy link
Member

macsko commented Sep 3, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e8aa2f7669e0a97b9f14220ff360441c58c74f21

@aimuz
Copy link
Contributor

aimuz commented Sep 3, 2024

/test pull-kubernetes-unit

@sanposhiho
Copy link
Member Author

/assign @alculquicondor

for approval

@sanposhiho
Copy link
Member Author

/retest

1 similar comment
@sanposhiho
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4bc6a11 into kubernetes:master Sep 3, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 3, 2024
@sanposhiho
Copy link
Member Author

@alculquicondor Sorry, I forgot /holding this. If you have any review points, then I could open a follow up PR to fix them.

@alculquicondor
Copy link
Member

no worries, it LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi Awaiting requested review from damemi

@denkensk denkensk Awaiting requested review from denkensk

@macsko macsko Awaiting requested review from macsko

Assignees

@alculquicondor alculquicondor

@macsko macsko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@sanposhiho @k8s-ci-robot @macsko @aimuz @alculquicondor