Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump images, dependencies and versions to go 1.23.0 #127076

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Bump images, dependencies and versions to go 1.23.0 #127076

merged 1 commit into from
Sep 3, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 2, 2024

What type of PR is this?

/kind feature
/hold

What this PR does / why we need it:

  • Bump images, dependencies and versions to go 1.23.0

Which issue(s) this PR fixes:

Part of kubernetes/release#3650

/assign @MadhavJivrajani @liggitt @puerco @xmudrii @saschagrunert
cc @kubernetes/release-managers

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with go 1.23.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 2, 2024
@cpanato
Bump images, dependencies and versions to go 1.23.0
b0c17b1 
Signed-off-by: cpanato <ctadeu@gmail.com>
@tt-kkaiser
Copy link

@cpanato Isn't this a duplicate of #126992? (I can close my pull request if you prefer to proceed with yours.)

@cpanato
Copy link
Member Author

cpanato commented Sep 2, 2024

@cpanato Isn't this a duplicate of #126992? (I can close my pull request if you prefer to proceed with yours.)

@tt-kkaiser Sorry, this work was coordinated in the sig-release (release engineering team), and the images were not published when you opened the pr. But if you want to help please show up in the sig-release meetings, then we can have a better coordination and avoid duplications

@tt-kkaiser
Copy link

Oh okay, I asked in the sig-release slack about it. The reason I opened my pull request in the first place was to resolve the issue I had with kubernetes (#126965) and not really as a new release for kubernetes.

@cpanato
Copy link
Member Author

cpanato commented Sep 2, 2024

Oh okay, I asked in the sig-release slack about it. The reason I opened my pull request in the first place was to resolve the issue I had with kubernetes (#126965) and not really as a new release for kubernetes.

there are a lot of other things to happen before opening the PR, we need to have other things in place, please, before doing anything, talk with us in Slack.

@tt-kkaiser
Copy link

Okay, thanks for the info, for next time i'll let you know in slack beforehand and not afterwards.

saschagrunert
saschagrunert approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dims
Copy link
Member

dims commented Sep 3, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 22327cdd4c0232d77bce6d36061aabeee7cf74b4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@cpanato
Copy link
Member Author

cpanato commented Sep 3, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1a0804c into kubernetes:master Sep 3, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 3, 2024
@cpanato cpanato deleted the update-go123 branch September 3, 2024 16:16
This was referenced Sep 4, 2024
Closed
Merged
@liggitt liggitt mentioned this pull request Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@dims dims Awaiting requested review from dims

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@cpanato @k8s-ci-robot @tt-kkaiser @dims @saschagrunert