Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4633: Graduate to BETA. #127009

Merged
merged 1 commit into from
Sep 4, 2024
Merged

KEP-4633: Graduate to BETA. #127009

merged 1 commit into from
Sep 4, 2024

Conversation

vinayakankugoyal
Copy link
Contributor

@vinayakankugoyal vinayakankugoyal commented Aug 29, 2024 •
edited by liggitt
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Sets the feature-gate AnonymousAuthConfigurableEndpoints to default to true as part of the BETA graduation of KEP kubernetes/enhancements#4633.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Graduate the AnonymousAuthConfigurableEndpoints feature gate to beta and enable by default to allow configurable endpoints for anonymous authentication.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/4633
- [Usage]: https://kubernetes.io/docs/reference/access-authn-authz/authentication/#anonymous-authenticator-configuration

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 29, 2024
@vinayakankugoyal
Copy link
Contributor Author

/test all

@vinayakankugoyal vinayakankugoyal mentioned this pull request Aug 29, 2024
Open
16 tasks
@vinayakankugoyal
Copy link
Contributor Author

/test all

@vinayakankugoyal
KEP-4633: Graduate to BETA.
8a4e23e 
Signed-off-by: Vinayak Goyal <vinaygo@google.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2024
@vinayakankugoyal
Copy link
Contributor Author

/test all

@liggitt liggitt marked this pull request as ready for review September 3, 2024 19:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2024
@k8s-ci-robot k8s-ci-robot requested review from liggitt and ncdc September 3, 2024 19:58
@liggitt
Copy link
Member

liggitt commented Sep 3, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2440e7b4689789acf435c2deba640b84f17f18ca

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@Jefftree
Copy link
Member

Jefftree commented Sep 3, 2024

/sig auth
/remove-sig api-machinery
/cc

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8b664fd into kubernetes:master Sep 4, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 4, 2024
@vinayakankugoyal vinayakankugoyal mentioned this pull request Sep 4, 2024
Merged
@Jefftree Jefftree mentioned this pull request Sep 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siyuanfoundation siyuanfoundation siyuanfoundation left review comments

@apelisse apelisse Awaiting requested review from apelisse

@liggitt liggitt Awaiting requested review from liggitt

@ncdc ncdc Awaiting requested review from ncdc

@Jefftree Jefftree Awaiting requested review from Jefftree

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@vinayakankugoyal @k8s-ci-robot @liggitt @Jefftree @siyuanfoundation