-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy/metrics: refactor nfacct metrics #126952
proxy/metrics: refactor nfacct metrics #126952
Conversation
Signed-off-by: Daman Arora <aroradaman@gmail.com>
Skipping CI for Draft Pull Request. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/release-note-none |
/test all |
/assign @danwinship |
/test pull-kubernetes-e2e-gce |
/assign @aojea |
/lgtm |
LGTM label has been added. Git tree hash: 79a014e54f431dea44f229880e8be9f6af64cfc8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, aroradaman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
With this PR nfacct client for kube-proxy metrics will only be initialized when RegisterMetrics is called, preventing unnecessary initialisation .
Which issue(s) this PR fixes:
Fixes #126951
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: