Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generally available feature gate MinDomainsInPodTopologySpread #126863

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Remove generally available feature gate MinDomainsInPodTopologySpread #126863

merged 1 commit into from
Sep 11, 2024
+0 −33

Conversation

carlory
Copy link
Member

@carlory carlory commented Aug 22, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

GA: v1.30

A follow-up of #123481

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed generally available feature gate `MinDomainsInPodTopologySpread`

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 22, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 22, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 22, 2024
@carlory carlory mentioned this pull request Aug 22, 2024
Merged
@carlory
Copy link
Member Author

carlory commented Aug 22, 2024

/sig scheduling
/cc @sanposhiho

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 22, 2024
sanposhiho
sanposhiho approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 874c8dccb1c75e2564efd14adb0ba9d72490cdbb

@carlory
Copy link
Member Author

carlory commented Aug 22, 2024

/assign @aojea

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@carlory carlory force-pushed the MinDomainsInPodTopologySpread branch from 624f739 to 8919e0c Compare September 5, 2024 02:27
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2024
@carlory carlory force-pushed the MinDomainsInPodTopologySpread branch from 8919e0c to c2a3009 Compare September 5, 2024 02:29
@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 5, 2024
@sanposhiho sanposhiho mentioned this pull request Sep 7, 2024
Closed
@carlory
Copy link
Member Author

carlory commented Sep 9, 2024

/test pull-kubernetes-integration

@sanposhiho
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ea0cd8424d1751fd0988ae85b6f82ea910ac63c8

@carlory
Copy link
Member Author

carlory commented Sep 10, 2024

/cc @aojea

@aojea
Copy link
Member

aojea commented Sep 11, 2024

It looks correct
/lgtm
/approve

@logicalhan can you PTAL to check the removal of feature gates with the versioning thing is correct?

/assign @thockin

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, carlory, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8e4d638 into kubernetes:master Sep 11, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 11, 2024
@carlory carlory deleted the MinDomainsInPodTopologySpread branch September 11, 2024 08:15
@Jefftree Jefftree mentioned this pull request Sep 19, 2024
Merged
@aaron-prindle aaron-prindle mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@aojea aojea Awaiting requested review from aojea

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees

@thockin thockin

@aojea aojea

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@carlory @k8s-ci-robot @sanposhiho @aojea @thockin