Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write e2e test for VolumeAttachmentStatus Endpoints +3 Endpoints #126827

Merged

Conversation

heyste
Copy link
Member

@heyste heyste commented Aug 20, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR adds a test to test the following untested endpoints:

  • patchStorageV1VolumeAttachmentStatus
  • readStorageV1VolumeAttachmentStatus
  • replaceStorageV1VolumeAttachmentStatus

Which issue(s) this PR fixes:

Fixes #126826

Special notes for your reviewer:

Adds +3 endpoint test coverage (good for conformance)

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig testing
/sig architecture
/area conformance

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Aug 20, 2024
@heyste
Copy link
Member Author

heyste commented Aug 20, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 20, 2024
@heyste heyste force-pushed the create-volume-attachment-status-test branch from e65d30c to fd8c5b7 Compare August 20, 2024 23:45
e2e test validates the following 3 endpoints
- patchStorageV1VolumeAttachmentStatus
- readStorageV1VolumeAttachmentStatus
- replaceStorageV1VolumeAttachmentStatus
@heyste heyste force-pushed the create-volume-attachment-status-test branch from fd8c5b7 to 4d228da Compare August 21, 2024 00:15
@riaankleinhans
Copy link
Contributor

/assign @xing-yang can you please review this PR or assign to the correct person to review?
Thank you!

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 83e039ade497f70c6e72dcbbdd46aa27bf6ba928

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heyste, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 39b57c0 into kubernetes:master Sep 4, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write e2e test for VolumeAttachmentStatus Endpoints +3 Endpoints
4 participants