Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ncdc to emeritus #126760

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Move ncdc to emeritus #126760

merged 2 commits into from
Sep 20, 2024

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Aug 17, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I am moving myself to emeritus as I am now firmly on the end-user side of things.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@ncdc
Move ncdc to emeritus
3ab816d 
I am moving myself to emeritus as I am now firmly on the end-user side
of things.

Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 17, 2024
@k8s-ci-robot k8s-ci-robot added area/apiserver area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 17, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@fedebongio
Copy link
Contributor

/assign @jpbetz @janetkuo @BenTheElder

Assigning one person from each SIG
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 22, 2024
@janetkuo
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 961d245dd432f894829f27f4f2c23db34fe92aa4

BenTheElder
BenTheElder reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs: https://go.k8s.io/owners

bikeshedding here, but we usually use emeritus_approvers field (like approvers) which could be read by tooling 😅

Thank you for PR-ing yourself out when you don't have the time.

@ncdc
Copy link
Member Author

ncdc commented Aug 22, 2024

bikeshedding here, but we usually use emeritus_approvers field

I'll make the change. I was following what is in OWNERS_ALIASES

@BenTheElder
Copy link
Member

I'll make the change. I was following what is in OWNERS_ALIASES

👍

I don't think we ever settled on something like this for OWNERS_ALIASES actually ... but we have pretty consistently used emeritus_approvers in OWNERS.

cc @kubernetes/sig-contributor-experience

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 22, 2024
@ncdc
Copy link
Member Author

ncdc commented Aug 22, 2024

@BenTheElder ok I made the change everywhere, including OWNERS_ALIASES. Might not be what we want. PTAL & let me know. Thanks!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 22, 2024
@ncdc
Copy link
Member Author

ncdc commented Aug 22, 2024

Now I see why they were commented out in OWNERS_ALIASES

@ncdc
Use emeritus_*
0e228be 
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 22, 2024
@liggitt
Copy link
Member

liggitt commented Sep 20, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 976f9c1187f513691690cc611a6fff527b2713e2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, liggitt, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@ncdc
Copy link
Member Author

ncdc commented Sep 20, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit f9a57ba into kubernetes:master Sep 20, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@janetkuo janetkuo Awaiting requested review from janetkuo

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@jpbetz jpbetz

@BenTheElder BenTheElder

@liggitt liggitt

@janetkuo janetkuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
8 participants
@ncdc @k8s-triage-robot @fedebongio @janetkuo @k8s-ci-robot @BenTheElder @liggitt @jpbetz