Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow k8s.io and kubernetes.io namespaced extra key in structured authn config #126553

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Disallow k8s.io and kubernetes.io namespaced extra key in structured authn config #126553

merged 1 commit into from
Aug 15, 2024

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 5, 2024

What type of PR is this?

/kind api-change

What this PR does / why we need it:

Disallow k8s.io and kubernetes.io namespaced extra key in structured authentication configuration

Which issue(s) this PR fixes:

Fixes #126495

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Disallow `k8s.io` and `kubernetes.io` namespaced extra key in structured authentication configuration.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/3331-structured-authentication-configuration

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.31 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.31.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 5 22:53:35 UTC 2024.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 5, 2024
@aramase
Copy link
Member Author

aramase commented Aug 5, 2024

/sig auth
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 5, 2024
@aramase
Copy link
Member Author

aramase commented Aug 5, 2024

/uncc mikedanese pwittrock
/assign enj liggitt

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@aramase
Copy link
Member Author

aramase commented Aug 12, 2024

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 12, 2024
enj
enj suggested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, LGTM otherwise.

staging/src/k8s.io/apiserver/pkg/apis/apiserver/validation/validation.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/apis/apiserver/validation/validation_test.go Show resolved Hide resolved
@aramase aramase force-pushed the aramase/c/kep_3331_disallow_k8s_io_prefix branch from 4db78ab to 228ddd4 Compare August 13, 2024 17:32
@aramase aramase requested a review from enj August 13, 2024 17:32
@enj
Copy link
Member

enj commented Aug 13, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f2e94e21f3e8d0a08fa74725d0244243b74200e

@liggitt
Copy link
Member

liggitt commented Aug 15, 2024

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Aug 15, 2024
@aramase
Disallow k8s.io and kubernetes.io namespaced extra key in structured …
89c619f 
…authn config

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/c/kep_3331_disallow_k8s_io_prefix branch from 228ddd4 to 89c619f Compare August 15, 2024 16:54
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2024
@k8s-ci-robot k8s-ci-robot requested a review from liggitt August 15, 2024 16:54
@liggitt
Copy link
Member

liggitt commented Aug 15, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 57b22029d596a3d96c4cbdffd5597608e595559f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit f26cf38 into kubernetes:master Aug 15, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Aug 15, 2024
@aramase aramase deleted the aramase/c/kep_3331_disallow_k8s_io_prefix branch August 15, 2024 18:21
@aramase aramase mentioned this pull request Sep 6, 2024
Merged
@enj enj mentioned this pull request Oct 31, 2024
Open
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj Awaiting requested review from enj

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@enj enj

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.32
SIG Auth
Archived in project
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.

Disallow k8s.io and kubernetes.io namespaced extra info in structured authentication configuration
5 participants
@aramase @k8s-ci-robot @k8s-triage-robot @enj @liggitt