Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ConsistentListFromCache to Beta default again #126469

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Move ConsistentListFromCache to Beta default again #126469

merged 1 commit into from
Jul 31, 2024

Conversation

serathius
Copy link
Contributor

@serathius serathius commented Jul 30, 2024 •
edited
Loading

With #126467 we got green light from api machinery to move forward with beta.

Reverts #126139

What type of PR is this?

/triage accepted
/kind feature
/kind api-change
/priority important-soon

Move ConsistentListFromCache feature flag to Beta and enable it by default

cc @liggitt @deads2k @wojtek-t

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 30, 2024
@k8s-ci-robot k8s-ci-robot requested review from apelisse and thockin July 30, 2024 20:52
@liggitt
Copy link
Member

liggitt commented Jul 30, 2024

with #126467 in place, this lgtm

/assign @deads2k

logicalhan
logicalhan reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/assign @liggitt @deads2k

@deads2k
Copy link
Contributor

deads2k commented Jul 30, 2024

/lgtm
/approve
/milestone v1.31
/hold

This also needs an ack from the release team (I support this exception).

@enj tested the changes in #126467

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3ccba1fcfbe82fed2581f6af5f4c38ea5c5c9fa5

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jul 30, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, logicalhan, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024
@serathius
Copy link
Contributor Author

/retest

@neoaggelos
Copy link

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Jul 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit eb729d1 into kubernetes:master Jul 31, 2024
15 checks passed
This was referenced Jul 31, 2024
Merged
Merged
@sftim
Copy link
Contributor

sftim commented Jul 31, 2024 •
edited
Loading

Changelog suggestion

-Move ConsistentListFromCache feature flag to Beta and enable it by default
+Graduated the API server's ability to serve collections from its watch cache, to beta.
+The `ConsistentListFromCache` feature gate is now enabled by default, and the
+API server therefore responds to **list** requests from that cache whenever possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan left review comments

@apelisse apelisse Awaiting requested review from apelisse

@thockin thockin Awaiting requested review from thockin

Assignees

@logicalhan logicalhan

@liggitt liggitt

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
8 participants
@serathius @liggitt @deads2k @k8s-ci-robot @neoaggelos @k8s-triage-robot @sftim @logicalhan