Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax noise margin in TestOneWeightedHistogram #126344

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Relax noise margin in TestOneWeightedHistogram #126344

merged 1 commit into from
Jul 27, 2024

Conversation

MikeSpreitzer
Copy link
Member

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

This PR relaxes the noise margin in TestOneWeightedHistogram, because that test occasionally fails (just barely). This PR also improves the logging a little.

Which issue(s) this PR fixes:

Fixes #120112

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2024
@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 24, 2024
@MikeSpreitzer
Relax noise margin in TestOneWeightedHistogram
77541c1 
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
@MikeSpreitzer MikeSpreitzer mentioned this pull request Jul 24, 2024
Closed
@MikeSpreitzer
Copy link
Member Author

/cc @BenTheElder
/cc @mengjiao-liu

@aojea
Copy link
Member

aojea commented Jul 24, 2024

/assign @logicalhan @dgrisonnet

dgrisonnet
dgrisonnet approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 39d0654e67afaef2a5382bd009ef7a080d01265d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, MikeSpreitzer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@dgrisonnet
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 25, 2024
@pacoxu
Copy link
Member

pacoxu commented Jul 26, 2024

This fixed a test failure. We may add the milestone v1.31 for it.

@MikeSpreitzer
Copy link
Member Author

/milestone v1.31

@k8s-ci-robot
Copy link
Contributor

@MikeSpreitzer: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MikeSpreitzer
Copy link
Member Author

@kubernetes/milestone-maintainers : I think this belongs in the 1.31 release, please see above.

@BenTheElder
Copy link
Member

/test pull-kubernetes-e2e-kind
#126401

@neoaggelos
Copy link

/milestone v1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jul 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2aa468c into kubernetes:master Jul 27, 2024
14 checks passed
@MikeSpreitzer MikeSpreitzer deleted the fix-120112 branch July 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@rexagod rexagod Awaiting requested review from rexagod

@serathius serathius Awaiting requested review from serathius

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

Assignees

@logicalhan logicalhan

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

[flaking test] k8s.io/kubernetes/vendor/k8s.io/component-base/metrics: TestOneWeightedHistogram
8 participants
@MikeSpreitzer @aojea @k8s-ci-robot @dgrisonnet @pacoxu @BenTheElder @neoaggelos @logicalhan