Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sig/etcd labels for related directories #125679

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Add sig/etcd labels for related directories #125679

merged 2 commits into from
Jun 25, 2024

Conversation

dims
Copy link
Member

@dims dims commented Jun 24, 2024

Since we now have a sig/etcd label, we should use it to tag PRs which touch on areas related to etcd. So we can ask folks interested to find/review these better.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@dims
Add sig/etcd labels for related directories
1390ac0 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/kubeadm area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 24, 2024
@dims
Copy link
Member Author

dims commented Jun 24, 2024

/assign @serathius
/sig etcd

:)

@k8s-ci-robot k8s-ci-robot added the sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. label Jun 24, 2024
neolit123
neolit123 reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dims i think we should add sig etcd only to these areas:

  • test/integration/etcd/OWNERS
  • cluster/images/etcd-*/OWNERS

i don't think we should try to inject ownership in areas such as kube-apiserver / kube-aggreggator / kubeadm. maybe that can be done only after explicit requests from those SIGs.

but anyway, if api-machinery are OK with the storage ownership, let's drop the kubeadm bits at least, since the etcd client integration and server preparation is spread all over kubeadm.

EDIT: but maybe we can apply area/etcd in all these places though.

cmd/kubeadm/app/phases/etcd/OWNERS Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/etcd/OWNERS Outdated Show resolved Hide resolved
cluster/images/etcd/OWNERS Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/OWNERS Outdated Show resolved Hide resolved
staging/src/k8s.io/kube-aggregator/OWNERS Outdated Show resolved Hide resolved
@dims
Copy link
Member Author

dims commented Jun 25, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2024
@dims dims force-pushed the add-sig/etcd-labels-for-related-directories branch from 1df8d1c to e6e3d7d Compare June 25, 2024 10:41
@dims
drop OWNERS in kubeadm
16e2451 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the add-sig/etcd-labels-for-related-directories branch from e6e3d7d to 16e2451 Compare June 25, 2024 10:42
@dims
Copy link
Member Author

dims commented Jun 25, 2024

/assign @liggitt

cc @kubernetes/sig-api-machinery-members

@liggitt
Copy link
Member

liggitt commented Jun 25, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4613c322edfd806867e8f798c5d615b1d904260b

@jpbetz
Copy link
Contributor

jpbetz commented Jun 25, 2024

/approve
For SIG API Machinery

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member Author

dims commented Jun 25, 2024

/hold cancel

thanks @jpbetz @liggitt

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit f848e4d into kubernetes:master Jun 25, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 25, 2024
@cici37
Copy link
Contributor

cici37 commented Jul 9, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 9, 2024
This was referenced Oct 20, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@liggitt liggitt

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubeadm area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
7 participants
@dims @liggitt @k8s-ci-robot @jpbetz @cici37 @neolit123 @serathius