Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add statusz endpoint for apiserver #125577

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add statusz endpoint for apiserver #125577

merged 1 commit into from
Nov 8, 2024

Conversation

richabanker
Copy link
Contributor

@richabanker richabanker commented Jun 19, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a /statusz page for apiserver

Which issue(s) this PR fixes:

kubernetes/enhancements#4827

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds a /statusz endpoint for kube-apiserver endpoint

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

sample response

kube-apiserver statusz
Warning: This endpoint is not meant to be machine parseable, has no formatting compatibility guarantees and is for debugging purposes only.

Started: Wed Oct 16 21:03:43 UTC 2024
Up: 0 hr 00 min 16 sec
Go version: go1.23.2
Binary version: 1.32.0-alpha.0.1484+5eeac4f21a491b-dirty
Emulation version: 1.32.0-alpha.0.1484

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 19, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and tkashem June 19, 2024 03:32
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 19, 2024
@richabanker richabanker force-pushed the statusz branch 2 times, most recently from 094ce07 to e9b1e4f Compare June 20, 2024 03:28
@richabanker richabanker force-pushed the statusz branch 4 times, most recently from 78deab7 to 381c8c6 Compare September 5, 2024 20:37
@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Sep 6, 2024
@richabanker richabanker force-pushed the statusz branch 5 times, most recently from 4f8156e to b26459d Compare September 6, 2024 06:07
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and rexagod November 7, 2024 15:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jpbetz, rexagod, richabanker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richabanker
Copy link
Contributor Author

/unhold
Moved installation of the handler to pkg/controlplane/apiserver/server.go, so now the response payload shows "kube-apiserver"

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
@richabanker
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

1 similar comment
@richabanker
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@richabanker
Copy link
Contributor Author

/skip pull-kubernetes-e2e-capz-windows-master

@jpbetz
Copy link
Contributor

jpbetz commented Nov 7, 2024

/lgtm

2 similar comments
@jpbetz
Copy link
Contributor

jpbetz commented Nov 7, 2024

/lgtm

@jpbetz
Copy link
Contributor

jpbetz commented Nov 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 35ac2673f7051fe46e7947feaae483576cbfa7ce

1 similar comment
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 35ac2673f7051fe46e7947feaae483576cbfa7ce

@Jefftree
Copy link
Member

Jefftree commented Nov 7, 2024

fyi you'll probably have merge conflicts with the flagz PR, might be good to let one merge first than letting them race since prow batches merge testing.

@richabanker
Copy link
Contributor Author

fyi you'll probably have merge conflicts with the flagz PR, might be good to let one merge first than letting them race since prow batches merge testing.

Right, applying a hold on this one till the other merges

@richabanker
Copy link
Contributor Author

/hold

till #127581 merges

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
@richabanker
Copy link
Contributor Author

richabanker commented Nov 8, 2024 •
edited
Loading

/unhold
oof looks like this one has already entered the queue, I'll unblock this and apply the hold on the other one

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@richabanker richabanker mentioned this pull request Nov 8, 2024
Merged
@k8s-ci-robot k8s-ci-robot merged commit 60651eb into kubernetes:master Nov 8, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Nov 8, 2024
@richabanker richabanker deleted the statusz branch November 8, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefftree Jefftree Jefftree left review comments

@aojea aojea aojea left review comments

@liggitt liggitt liggitt left review comments

@logicalhan logicalhan logicalhan left review comments

@jpbetz jpbetz jpbetz left review comments

@hashim21223445 hashim21223445 hashim21223445 approved these changes

@tkashem tkashem Awaiting requested review from tkashem

@deads2k deads2k Awaiting requested review from deads2k

@pohly pohly Awaiting requested review from pohly

@dims dims Awaiting requested review from dims

@rexagod rexagod Awaiting requested review from rexagod

Assignees

@dims dims

@jpbetz jpbetz

@rexagod rexagod

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
SIG Auth
Archived in project
SIG CLI
Archived in project
SIG Node CI/Test Board
Status: Done
SIG Node: code and documentation PRs
Status: Done
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.