Update travis and shippable to have less needless cruft #12553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eparis
force-pushed
the
travis-shippable-cleanup
branch
from
0f99c2c to
0726ef3
Compare
It looks like there are places where things were needed for one command were being just needlessly copied. Which made the files harder to recognize what mattered and what didn't...
eparis
force-pushed
the
travis-shippable-cleanup
branch
from
0726ef3 to
df98870
Compare
|
@mikedanese since you are looking at these guys. |
eparis
changed the title
|
LGTM. Thanks! |
|
GCE e2e build/test passed for commit df98870. |
mikedanese
added
the
lgtm
cjcullen
added a commit
that referenced
this pull request
Aug 12, 2015
Update travis and shippable to have less needless cruft
|
What's the reason for removing these? I don't see what's so harmful about having extraneous PATH entries. I'm all for cleaning up our bash scripts and test config, but it seems strange to provide different scripts with different environments. This subtly breaks shippable when combined with #12411, and whether you agree with the decision to add a new build dep in that PR or not, I don't think we want surprises like this in our test config. |
|
These definitely need "undone" for deep-copy and conversions. If we want consistency across all scripts that's fine. But that means we should just explicitly export the PATH for everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there are places where things needed for one command
were being just needlessly copied. Which made the files harder to
recognize what mattered and what didn't...