• ✅login: mas9612 / (bcd1d84)

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Welcome @mas9612!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @mas9612. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/ok-to-test

LGTM, but I'm note sure there is point updating the change log now, since this will probably not update it here: https://github.com/kubernetes/kubernetes/releases. Also 1.28 is EOL nest month ( 2024-10-28 ) https://kubernetes.io/releases/patch-releases/#1-28

Thank you for the review!
I happened to notice it while at work earlier and if it is no longer needed, please close it without merging.

I'm not 100% sure about the policy here, so let me check with release managers
/cc @kubernetes/release-managers

@mimowo Updating changelogs is generally considered fine at least for the supported releases (and we can count 1.28 as supported in this context). But to complete the process, you would also need to cherry-pick this change to the release-1.28 branch. That said, if you folks want to proceed with this PR, it should be fine.

I'm personally 👍 for updating this. It might not seem like a whole lot, but for folks actually going through changelogs this might be a time saver. I'm not sure about the mechanics of this PR, especially about the feasibility of a cherry-pick, but I'll let the release managers to deal with that.

With my sig-apps hat on - I approve 😄

+1
/lgtm
/test pull-kubernetes-e2e-kind-ipv6

LGTM label has been added.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mas9612, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@mas9612: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

/test pull-kubernetes-integration

@mas9612 please prepare the cherry-pick PR for 1.28

Thank you!
I created cherry-pick PR #127674