Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-2400]: Swap e2e tests: skip swap stress tests if swap is not provisioned #125402

Merged
merged 1 commit into from
Jun 25, 2024
Merged

[KEP-2400]: Swap e2e tests: skip swap stress tests if swap is not provisioned #125402

merged 1 commit into from
Jun 25, 2024

Conversation

iholder101
Copy link
Contributor

What type of PR is this?

/kind feature
/kind failing-test

What this PR does / why we need it:

Skips swap stress tests if swap is not provisioned on the node.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2400-node-swap

@iholder101
skip swap stress tests if swap is not provisioned
37d8051 
Signed-off-by: Itamar Holder <iholder@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 10, 2024
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and dims June 10, 2024 07:08
@iholder101 iholder101 mentioned this pull request Jun 10, 2024
Merged
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 10, 2024
@iholder101
Copy link
Contributor Author

/cc @ffromani

@k8s-ci-robot k8s-ci-robot requested a review from ffromani June 10, 2024 07:08
@iholder101 iholder101 changed the title Swap e2e tests: skip swap stress tests if swap is not provisioned [KEP2400]: Swap e2e tests: skip swap stress tests if swap is not provisioned Jun 10, 2024
@iholder101 iholder101 changed the title [KEP2400]: Swap e2e tests: skip swap stress tests if swap is not provisioned [KEP-2400]: Swap e2e tests: skip swap stress tests if swap is not provisioned Jun 10, 2024
ffromani
ffromani reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

do we want or need (in a future separate work of course) a separate lane to make sure swap is provisioned?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 18dd3223248dfceea7626ad196066b2f530ce3c8

@ffromani
Copy link
Contributor

/triage accepted
/priority important-soon

simple fix to improve the signal for CI avoiding false negatives

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 10, 2024
@iholder101
Copy link
Contributor Author

iholder101 commented Jun 10, 2024 •
edited
Loading

/lgtm

do we want or need (in a future separate work of course) a separate lane to make sure swap is provisioned?

We've created the swap-conformance lanes especially for that :)

@ffromani ffromani mentioned this pull request Jun 10, 2024
Merged
@pacoxu
Copy link
Member

pacoxu commented Jun 13, 2024

/assign @SergeyKanzhelev @endocrimes
for approval

@ffromani ffromani mentioned this pull request Jun 14, 2024
Merged
@iholder101 iholder101 mentioned this pull request Jun 19, 2024
Closed
@bitoku bitoku mentioned this pull request Jun 19, 2024
Merged
@pacoxu
Copy link
Member

pacoxu commented Jun 25, 2024

/assign @SergeyKanzhelev @endocrimes @mrunalp
for approval
(CI bot missed last assignment)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iholder101, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0913b90 into kubernetes:master Jun 25, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 25, 2024
@pacoxu pacoxu mentioned this pull request Aug 9, 2024
Open
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani ffromani left review comments

@mrunalp mrunalp mrunalp approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@dims dims Awaiting requested review from dims

Assignees

@mrunalp mrunalp

@endocrimes endocrimes

@SergeyKanzhelev SergeyKanzhelev

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
7 participants
@iholder101 @k8s-ci-robot @ffromani @pacoxu @mrunalp @endocrimes @SergeyKanzhelev