Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: use the actual configured kubelet healthz address:port #125265

Merged
merged 1 commit into from
Jun 3, 2024
Merged

kubeadm: use the actual configured kubelet healthz address:port #125265

merged 1 commit into from
Jun 3, 2024

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Jun 1, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

When doing a kubelet health check on init/join, do not hardcode the "localhost" address. Instead, use the KubeletConfiguration HealthzBindAddress and HealthzPort fields.

This fixes the following issues:

  • the user has configured the kubelet heatlhz but kubeadm does not respect it
  • localhost does not resolve to 127.0.0.1 which is the default bind address for the kubelet helathz

Which issue(s) this PR fixes:

xref kubernetes/kubeadm#3069

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubeadm: during kubelet health checks, respect the healthz address:port configured in the KubeletConfiguration instead of hardcoding localhost:10248.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@neolit123
kubeadm: use the actual configured kubelet healthz address:port
52302e4 
When doing a kubelet health check on init/join, do not
hardcode the "localhost" address. Instead, use the
KubeletConfiguration HealthzBindAddress and HealthzPort
fields.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Jun 1, 2024
@k8s-ci-robot k8s-ci-robot requested review from carlory and SataQiu June 1, 2024 07:15
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 1, 2024
@neolit123 neolit123 mentioned this pull request Jun 1, 2024
Closed
@neolit123
Copy link
Member Author

neolit123 commented Jun 1, 2024 •
edited
Loading

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 1, 2024
pacoxu
pacoxu approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4547076380743916565cb5dceeaf186ffb71f780

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member Author

/hold cancel
backport to 1.30 comming soon.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2024
@neolit123 neolit123 mentioned this pull request Jun 3, 2024
Merged
@k8s-ci-robot k8s-ci-robot merged commit 2d8a3ad into kubernetes:master Jun 3, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 3, 2024
k8s-ci-robot added a commit that referenced this pull request Jun 3, 2024
@k8s-ci-robot
Merge pull request #125286 from neolit123/automated-cherry-pick-of-#1…
d8abab9 
…25265-origin-release-1.30

Automated cherry pick of #125265: kubeadm: use the actual configured kubelet healthz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu approved these changes

@carlory carlory Awaiting requested review from carlory

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
3 participants
@neolit123 @k8s-ci-robot @pacoxu