Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1880 Multiple Service CIDRs: Graduate to Beta (2/2) #125021

Merged
merged 10 commits into from
Jun 30, 2024
Merged

KEP-1880 Multiple Service CIDRs: Graduate to Beta (2/2) #125021

merged 10 commits into from
Jun 30, 2024

Conversation

aojea
Copy link
Member

@aojea aojea commented May 21, 2024 •
edited
Loading

/kind feature

Update the ServiceCIDR feature gate and APIs to beta

KEP kubernetes/enhancements#1880

Update the feature MultiCIDRServiceAllocator to beta (disabled by default). Users need to enable the feature gate and the networking v1beta1 group to be able to use this new feature, that allows to dynamically reconfigure Service CIDR ranges.

- [KEP]: https://github.com/kubernetes/enhancements/issues/1880

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/code-generation area/kube-proxy area/kubectl area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 21, 2024
@aojea aojea force-pushed the servicecidrbeta branch from 8bc4341 to dd6d5f3 Compare May 21, 2024 13:42
@aojea aojea changed the title KEP-1880 Multiple Service CIDRs: Graduate to Beta (2/2) [WIP] KEP-1880 Multiple Service CIDRs: Graduate to Beta (2/2) May 21, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2024
@aojea aojea force-pushed the servicecidrbeta branch from dd6d5f3 to 74c1bc5 Compare May 21, 2024 16:23
@aojea aojea marked this pull request as draft May 21, 2024 16:23
@aojea aojea mentioned this pull request May 24, 2024
Open
12 tasks
@aojea aojea force-pushed the servicecidrbeta branch from 74c1bc5 to 3fd2481 Compare May 28, 2024 11:21
@aojea aojea force-pushed the servicecidrbeta branch from e3fb9ce to 8eccdff Compare June 28, 2024 13:49
aojea
aojea commented Jun 28, 2024
View reviewed changes
pkg/kubeapiserver/default_storage_factory_builder.go
Comment on lines -74 to +75
networking.Resource("ipaddresses").WithVersion("v1alpha1"),
networking.Resource("servicecidrs").WithVersion("v1alpha1"),
networking.Resource("ipaddresses").WithVersion("v1beta1"),
networking.Resource("servicecidrs").WithVersion("v1beta1"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt is this correct? I'm always confused with this part

@aojea aojea force-pushed the servicecidrbeta branch from 8eccdff to 578e339 Compare June 29, 2024 10:07
@aojea
Copy link
Member Author

aojea commented Jun 29, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@aojea aojea force-pushed the servicecidrbeta branch from 578e339 to 0dcb4da Compare June 29, 2024 18:40
@aojea
Copy link
Member Author

aojea commented Jun 30, 2024

/assign @thockin

mechanical changes for moving to beta

@aojea aojea force-pushed the servicecidrbeta branch from 0dcb4da to bc8bce2 Compare June 30, 2024 09:48
@thockin
Copy link
Member

thockin commented Jun 30, 2024

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cba44df4c7bf5b6d44b25cbb6f267e20dab226f7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 93d5651 into kubernetes:master Jun 30, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 30, 2024
@cici37
Copy link
Contributor

cici37 commented Jul 11, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 11, 2024
@aojea aojea mentioned this pull request Jul 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet left review comments

@dashpole dashpole dashpole left review comments

@brianpursley brianpursley Awaiting requested review from brianpursley

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@thockin thockin

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/kube-proxy area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
SIG CLI
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
7 participants
@aojea @cici37 @dgrisonnet @k8s-triage-robot @thockin @k8s-ci-robot @dashpole