-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guestbook updates: GCR images, support both dns service and env vars #12497
Conversation
This is towards #9107. |
GCE e2e build/test failed for commit 6243838cec5482d22a1ca8fb37cb5f70cd0e5935. |
GCE e2e build/test failed for commit bfbb9bcd263da6dd46adf6c49d58c8c768bafb69. |
GCE e2e build/test failed for commit 09f559143798ffa320f978c7e7a874d5b3affc26. |
The new version of the app, and the new GCR images, work fine for me™. I don't know why the jenkins test is failing. I'll try running the test again in a bit. |
GCE e2e build/test failed for commit 1119aee1404b8e5042735bfa239715f6dcee50f8. |
@brendanburns Brendan, the jenkins build has failed enough times that I no longer think it's a fluke. However, nothing jumps out at me from the build log. |
@k8s-bot test this please |
`GET_HOSTS_FROM` env value in both | ||
`examples/guestbook/redis-slave-controller.yaml` and `examples/guestbook/frontend-controller.yaml` | ||
from `dns` to `env` before you start up the app. | ||
(However, this is unlikely to be necessary. You can check for the DNS service in the list of the clusters' services, e.g. via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make these instructions more explicit:
kubectl --namespace=kube-system get rc kube-dns
or somesuch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
one minor comment, otherwise lgtm. I pinged Jenkins again. |
GCE e2e build/test failed for commit 1119aee1404b8e5042735bfa239715f6dcee50f8. |
Needs a rebase. |
Rebased. Let's see what Jenkins does this time. I did double check that the google_samples images were properly accessible from a personal account, and just ran through setting up the app again. All seems fine. If the build continues to fail I might need some assistance digging into why. |
GCE e2e build/test failed for commit 547c44a55cdb3c2014e3aec36a1ad515e5e3f4be. |
Jenkins is still broken. Are your images publically readable? |
Yes, they are readable-- I confirmed that just a regular 'docker pull' from a personal laptop (no gcloud installed etc.) works fine, and got someone else to confirm as well, just to double check. |
GCE e2e build/test failed for commit b64d386eea5532bdf53c7606fcba4a27c6f3f0a2. |
Unfortunately I'll have to punt on looking into this further until next week. Does seem like something's up, but as I noted above, it's all running fine for me. Maybe someone more familiar than me with the Jenkins setup can see if something jumps out at them. |
Labelling this PR as size/L |
GCE e2e build/test failed for commit ddeb284c4c111ab6bb20c8a113690fd574becfa0. |
I tried running this example from a personal account as well, to double check the gcr access, and again it worked fine. I think I will need to get some help/consultation to figure out the jenkins issue. |
… dns service is supported, or to use env vars to get service host info. Test change to reflect php filename change.
GCE e2e build/test passed for commit 3574999. |
hah! turned out I needed to change a test. |
LGTM, @amygdala thanks for finishing this out. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 3574999. |
Automatic merge from SubmitQueue |
Auto commit by PR queue bot
It seems that |
@sttts The build files, in the php-redis subdir, have incorporated those changes to the relative URLs -- https://github.com/kubernetes/kubernetes/pull/12497/files (check that those changes look as expected to you). |
$ docker run -it gcr.io/google_samples/gb-frontend:v2 cat index.html
<html ng-app="redis">
<head>
<title>Guestbook</title>
<link rel="stylesheet" href="//netdna.bootstrapcdn.com/bootstrap/3.1.1/css/bootstrap.min.css">
<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.12/angular.min.js"></script>
<script src="/controllers.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/angular-ui-bootstrap/0.13.0/ui-bootstrap-tpls.js"></script>
</head>
<body ng-controller="RedisCtrl">
<div style="width: 50%; margin-left: 20px">
<h2>Guestbook</h2>
<form>
<fieldset>
<input ng-model="msg" placeholder="Messages" class="form-control" type="text" name="input"><br>
<button type="button" class="btn btn-primary" ng-click="controller.onRedis()">Submit</button>
</fieldset>
</form>
<div>
<div ng-repeat="msg in messages track by $index">
{{msg}}
</div>
</div>
</div>
</body>
</html> Compare the line with |
@sttts yes, it looks like the image needs to be rebuilt. Sorry about that. |
@amygdala thanks for the fast fix 👍 |
Use GCR images from 'google-samples' project; allow switch on whether dns service is
supported, or to use env vars to get service host info.
Replaces #11787 .