Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet: refactor kubelet.Runtimehooks to container.ImagePuller. #12489

Merged
merged 1 commit into from
Aug 13, 2015
Merged

kubelet: refactor kubelet.Runtimehooks to container.ImagePuller. #12489

merged 1 commit into from
Aug 13, 2015

Conversation

yifan-gu
Copy link
Contributor

This PR wraps the runtime hook functions (ShouldPullImage, ReportImagePulling, ReportImagePulled) and DockerManger.pullImage to ImagePuller.PullImage.
This new function can be called by other container runtimes to pull image and report events, as long as the runtime has implemented IsImagePresent and PullImage in the runtime interface.

/cc @dchen1107 @vmarmol @yujuhong

@k8s-bot
Copy link

k8s-bot commented Aug 10, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@a-robinson
Copy link
Contributor

@k8s-bot ok to test

@k8s-bot
Copy link

k8s-bot commented Aug 10, 2015

GCE e2e build/test passed for commit 6cc54ba9893254dacfdaaa4799c154dc92ba9c1e.

@yifan-gu yifan-gu force-pushed the refactor_runtime_hooks branch from 6cc54ba to b7bc393 Compare August 10, 2015 20:06
@k8s-bot
Copy link

k8s-bot commented Aug 10, 2015

GCE e2e build/test passed for commit b7bc39328e52b21d2367f6a14c996877045516c4.

@yifan-gu yifan-gu force-pushed the refactor_runtime_hooks branch from b7bc393 to bf9217a Compare August 10, 2015 20:28
@k8s-bot
Copy link

k8s-bot commented Aug 10, 2015

GCE e2e build/test passed for commit bf9217a4e566c95f9fa7598a6af8b07d13081ed6.

@timothysc
Copy link
Member

/cc @pmorie

@yujuhong
Copy link
Contributor

@dchen1107, if you are busy, feel free to re-assign to me :)

@dchen1107
Copy link
Member

LGTM. Please rebase your pr to get this merged.

@yifan-gu yifan-gu force-pushed the refactor_runtime_hooks branch from bf9217a to dbf779b Compare August 12, 2015 01:31
@yifan-gu
Copy link
Contributor Author

@dchen1107 Rebased :)

@k8s-bot
Copy link

k8s-bot commented Aug 12, 2015

GCE e2e build/test passed for commit dbf779bb26e94b8a23701e91173392ffbd923d62.

@yifan-gu yifan-gu force-pushed the refactor_runtime_hooks branch 2 times, most recently from 40f13a6 to 58c748f Compare August 12, 2015 17:15
@k8s-bot
Copy link

k8s-bot commented Aug 12, 2015

GCE e2e build/test passed for commit 40f13a672ee7d30626d878ce3b083206650679d6.

@k8s-bot
Copy link

k8s-bot commented Aug 12, 2015

GCE e2e build/test passed for commit 58c748fdbf1397d19416e9698ad8944563ec0a93.

@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2015
@yifan-gu yifan-gu force-pushed the refactor_runtime_hooks branch from 58c748f to e22dbc9 Compare August 12, 2015 23:22
@yifan-gu yifan-gu force-pushed the refactor_runtime_hooks branch from e22dbc9 to d70a30c Compare August 12, 2015 23:28
@k8s-bot
Copy link

k8s-bot commented Aug 12, 2015

GCE e2e build/test passed for commit e22dbc9db5bd765a3f1bb71b0d52e52056cd3572.

@k8s-bot
Copy link

k8s-bot commented Aug 12, 2015

GCE e2e build/test passed for commit d70a30c.

cjcullen added a commit that referenced this pull request Aug 13, 2015
@cjcullen
Merge pull request #12489 from yifan-gu/refactor_runtime_hooks
6b86960 
kubelet: refactor kubelet.Runtimehooks to container.ImagePuller.
@cjcullen cjcullen merged commit 6b86960 into kubernetes:master Aug 13, 2015
@yifan-gu yifan-gu deleted the refactor_runtime_hooks branch August 13, 2015 00:16
@pmorie
Copy link
Member

pmorie commented Aug 17, 2015

I was OOO last week, but this LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@yifan-gu @k8s-bot @a-robinson @timothysc @yujuhong @dchen1107 @pmorie @googlebot @cjcullen