Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark volume.beta.kubernetes.io/mount-options as deprecated #124819

Merged
merged 1 commit into from
Jul 23, 2024
Merged

mark volume.beta.kubernetes.io/mount-options as deprecated #124819

merged 1 commit into from
Jul 23, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented May 11, 2024

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

pv.spec.mountOptions supports this feature. let's deprecate the annotation and send a warning first.

FYI: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#mount-options.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added a warning when creating or updating a PV with the deprecated annotation `volume.beta.kubernetes.io/mount-options`

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 11, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 11, 2024
@carlory
Copy link
Member Author

carlory commented May 11, 2024

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 11, 2024
@carlory
Copy link
Member Author

carlory commented May 11, 2024

/cc @xing-yang

@k8s-ci-robot k8s-ci-robot requested a review from xing-yang May 11, 2024 10:17
@carlory
Copy link
Member Author

carlory commented Jul 15, 2024

/cc @jsafrane

@k8s-ci-robot k8s-ci-robot requested a review from jsafrane July 15, 2024 07:54
@jsafrane
Copy link
Member

/lgtm
/approve
from sig-storage side

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d7366d228ae51e8436f07bbd80290611dff4654

@jsafrane
Copy link
Member

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Jul 23, 2024
@carlory
Copy link
Member Author

carlory commented Jul 23, 2024

/assign @smarterclayton @msau42

@msau42
Copy link
Member

msau42 commented Jul 23, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jsafrane, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 13d9d7c into kubernetes:master Jul 23, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jul 23, 2024
@carlory carlory deleted the add-warning-MountOptionAnnotation branch July 23, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@tallclair tallclair Awaiting requested review from tallclair

@xing-yang xing-yang Awaiting requested review from xing-yang

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@smarterclayton smarterclayton

@jsafrane jsafrane

@msau42 msau42

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
API Reviews
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
5 participants
@carlory @k8s-ci-robot @jsafrane @msau42 @smarterclayton