Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resourcequota: use singleflight.Group to reduce apiserver load #124163

Merged
merged 1 commit into from
Apr 18, 2024
Merged

resourcequota: use singleflight.Group to reduce apiserver load #124163

merged 1 commit into from
Apr 18, 2024

Conversation

flavianmissi
Copy link
Contributor

What type of PR is this?

/kind cleanup
/kind flake

What this PR does / why we need it:

Wraps up the code that requests the apiserver directly (without a lister) with a singleflight.Group.
This conforms to how the limit range admission plugin makes requests to the apiserver.
I'm also hoping this will fix a flaky replica set test, but since I can't reproduce the flake I cannot be sure.

Which issue(s) this PR fixes:

Relates to #22422 and #123806.

And inspired by #112696 and #114919.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. labels Apr 3, 2024
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.30 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.30.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Apr 3 02:18:49 UTC 2024.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 3, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @flavianmissi!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @flavianmissi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 3, 2024
@k8s-ci-robot k8s-ci-robot requested review from tkashem and wojtek-t April 3, 2024 08:41
@flavianmissi
Copy link
Contributor Author

/sig apps
/sig scalability
/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Apr 3, 2024
@atiratree
Copy link
Member

/ok-to-test
/kind bug
/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 3, 2024
atiratree
atiratree reviewed Apr 5, 2024
View reviewed changes
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 9, 2024
@flavianmissi flavianmissi force-pushed the resource-quota-single-flight branch from dbc3cc2 to 59258ae Compare April 9, 2024 15:12
@flavianmissi
Copy link
Contributor Author

I believe I have addressed all the review comments - PTAL when you have a moment.
Thanks!

@aojea
Copy link
Member

aojea commented Apr 9, 2024

lgtm
/assign @atiratree @liggitt

atiratree
atiratree reviewed Apr 10, 2024
View reviewed changes
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/resource_access_test.go Outdated Show resolved Hide resolved
@flavianmissi flavianmissi force-pushed the resource-quota-single-flight branch from 0daa128 to e13ff5e Compare April 10, 2024 13:55
@atiratree
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b719be2888be0939c87a1e863da51b359249d8a1

@liggitt
Copy link
Member

liggitt commented Apr 10, 2024

/lgtm
/approve
/milestone v1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7b33887 into kubernetes:master Apr 18, 2024
14 checks passed
@flavianmissi flavianmissi deleted the resource-quota-single-flight branch May 2, 2024 11:31
This was referenced May 27, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@atiratree atiratree atiratree left review comments

@tkashem tkashem Awaiting requested review from tkashem

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@liggitt liggitt

@atiratree atiratree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
5 participants
@flavianmissi @k8s-ci-robot @atiratree @aojea @liggitt