e2e test cases should clean up more effectively #12408
Merged
+77
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCE e2e build/test passed for commit 9e3c742ded50f7f247a9b1f1783e3c85cbf69971. |
|
Ping - trying to get this cleared so we can get graceful deletion unblocked |
|
|
||
| pods, err = podClient.List(labels.SelectorFromSet(labels.Set(map[string]string{"time": value})), fields.Everything()) | ||
| if err != nil { | ||
| Fail(fmt.Sprintf("Failed to delete pod: %v", err)) |
There was a problem hiding this comment.
this is more "failed to list" than "failed to delete", right?
smarterclayton
force-pushed
the
improvements_to_test
branch
from
9e3c742 to
479ba5c
Compare
|
Addressed feedback |
|
GCE e2e build/test passed for commit 479ba5cd7a62d7c3b9c8582f26127766ac24837b. |
|
other than those two issues, LGTM |
smarterclayton
force-pushed
the
improvements_to_test
branch
from
479ba5c to
e623d33
Compare
Graceful deletion exposes weakness in cleanup paths, add common hooks for waiting for namespcae deletion to complete, use direct delection where necessary, and add some debug output for finding cleanup flags (namespaces that aren't fully deleted)
|
GCE e2e build/test passed for commit e623d33. |
|
Comments addressed |
|
LGTM, thanks! |
ixdy
added
the
lgtm
a-robinson
added a commit
that referenced
this pull request
Aug 11, 2015
e2e test cases should clean up more effectively
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graceful deletion exposes weakness in cleanup paths, add
common hooks for waiting for namespace deletion to complete,
use direct delection where necessary, and add some debug output
for finding cleanup flags (namespaces that aren't fully deleted)
Extracted from #9165 - makes e2e more resilient to transients