Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-scheduler remove non-csi volumelimit plugins #124003

Merged
merged 1 commit into from
Aug 26, 2024
Merged

kube-scheduler remove non-csi volumelimit plugins #124003

merged 1 commit into from
Aug 26, 2024
+52 −1,735

Conversation

carlory
Copy link
Member

@carlory carlory commented Mar 20, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

See #123970

Which issue(s) this PR fixes:

Fixes #82375

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-scheduler removed the following plugins: 
- AzureDiskLimits 
- CinderLimits
- EBSLimits
- GCEPDLimits
Because the corresponding CSI driver reports how many volumes a node can handle in NodeGetInfoResponse, the kubelet stores this limit in CSINode and the scheduler then knows the driver's limit on the node.
ACTION REQUIRED: Remove plugins AzureDiskLimits, CinderLimits, EBSLimits and GCEPDLimits if you explicitly enabled them in the scheduler config.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 20, 2024
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 20, 2024
@carlory carlory force-pushed the scheduler-rm-non-csi-limit branch from b267eb6 to 7a01d65 Compare March 20, 2024 07:31
@k8s-ci-robot k8s-ci-robot added area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 20, 2024
@carlory
Copy link
Member Author

carlory commented Mar 20, 2024

/cc @jsafrane @msau42

@k8s-ci-robot k8s-ci-robot requested review from jsafrane and msau42 March 20, 2024 07:37
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@carlory
Copy link
Member Author

carlory commented Mar 21, 2024

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-integration

@dims
Copy link
Member

dims commented Mar 22, 2024

/test pull-kubernetes-integration

@carlory carlory force-pushed the scheduler-rm-non-csi-limit branch 3 times, most recently from ba04aad to 484775c Compare March 26, 2024 03:57
@carlory
Copy link
Member Author

carlory commented Apr 8, 2024

/cc @sanposhiho

@k8s-ci-robot k8s-ci-robot requested a review from sanposhiho April 8, 2024 02:18
@carlory carlory mentioned this pull request Apr 8, 2024
Closed
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2024
@jsafrane
Copy link
Member

jsafrane commented Aug 6, 2024

/lgtm
From storage point of view. Sadly, I can't help with approvals.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ec7a81752721c91770974cd55a3f05846cebc1ed

@sanposhiho
Copy link
Member

/approve

Per the discussion here, we should be able to merge it after the code freeze of v1.31.

cc @kerthcet for the cross-check.

@sanposhiho
Copy link
Member

Well, I guess SIG-Scheduling or SIG-Storage should own ↓ actually.. Currently no owner file and thus /tests/ owner owns them.
https://github.com/kubernetes/kubernetes/tree/master/test/integration/volumescheduling

@carlory carlory mentioned this pull request Aug 12, 2024
Merged
@carlory
Copy link
Member Author

carlory commented Aug 19, 2024

/assign @dchen1107

@carlory
Copy link
Member Author

carlory commented Aug 19, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2024
@carlory
Copy link
Member Author

carlory commented Aug 22, 2024

/cc @saad-ali @msau42 @aojea

Can you have a look?

@k8s-ci-robot k8s-ci-robot requested review from aojea and saad-ali August 22, 2024 06:02
pohly
pohly approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, pohly, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0bcbc3b into kubernetes:master Aug 26, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Aug 26, 2024
@carlory carlory deleted the scheduler-rm-non-csi-limit branch August 26, 2024 11:59
@alculquicondor
Copy link
Member

no action is required for users for this removal.

Is this 100% true?

If a user was explicitly enabling any of these plugins, they need to stop doing that and make sure not enable the CSI plugins.

@carlory
Copy link
Member Author

carlory commented Aug 26, 2024

@alculquicondor scheduler deprecated non-CSI volume limit plugins in 1.31. #124500

@carlory carlory mentioned this pull request Aug 26, 2024
Merged
@sanposhiho
Copy link
Member

no action is required for users for this removal.
Please just remove those plugins if you explicitly use those plugins in the scheduler config.

@carlory I think this part in the release note is contradictory.
better to remove "no action is required for users for this removal."

@carlory
Copy link
Member Author

carlory commented Aug 27, 2024

@sanposhiho removed

@alculquicondor
Copy link
Member

/release-note-edit

kube-scheduler removed the following plugins: 
- AzureDiskLimits 
- CinderLimits
- EBSLimits
- GCEPDLimits
Because the corresponding CSI driver reports how many volumes a node can handle in NodeGetInfoResponse, the kubelet stores this limit in CSINode and the scheduler then knows the driver's limit on the node.
ACTION REQUIRED: Remove plugins AzureDiskLimits, CinderLimits, EBSLimits and GCEPDLimits if you explicitly enabled them in the scheduler config.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 27, 2024
@pacoxu pacoxu mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerthcet kerthcet kerthcet left review comments

@pohly pohly pohly approved these changes

@chendave chendave Awaiting requested review from chendave

@mauriciopoppe mauriciopoppe Awaiting requested review from mauriciopoppe

@jsafrane jsafrane Awaiting requested review from jsafrane

@msau42 msau42 Awaiting requested review from msau42

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

@aojea aojea Awaiting requested review from aojea

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@jsafrane jsafrane

@dchen1107 dchen1107

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.

[scheduler] Remove deprecated EBS/GCE/Azure/Cinder predicates
10 participants
@carlory @k8s-ci-robot @k8s-triage-robot @dims @sanposhiho @jsafrane @alculquicondor @pohly @kerthcet @dchen1107