Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get node from local cache instead of kube-apiserver cache for kubelet status updates #123977

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Get node from local cache instead of kube-apiserver cache for kubelet status updates #123977

merged 1 commit into from
Apr 18, 2024

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Mar 18, 2024 •
edited
Loading

This allows to avoid majority of GET Node calls to kube-apiserver coming from kubelet - this call is happening every 10s by default, so we save #nodes/10 QPSes, which can be very substantial with large clusters.

/kind cleanup
/priority important-longterm
/sig-node

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 18, 2024
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 18, 2024
@matthyx
Copy link
Contributor

matthyx commented Mar 19, 2024

/triage accepted
/lgtm
/hold
@wojtek-t please unhold when needed, I just prevent auto merging

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 19, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e39ee25dc4a9724d326dad68ba29a1508ac4a08c

matthyx
matthyx approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat, thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matthyx, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

HirazawaUi
HirazawaUi reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@HirazawaUi HirazawaUi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a similar PR #123125

@wojtek-t wojtek-t removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit ca1a134 into kubernetes:master Apr 18, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 18, 2024
@linxiulei linxiulei mentioned this pull request Apr 30, 2024
Closed
@rifelpet rifelpet mentioned this pull request Jun 11, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HirazawaUi HirazawaUi HirazawaUi left review comments

@matthyx matthyx matthyx approved these changes

@rphillips rphillips Awaiting requested review from rphillips

Assignees

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
4 participants
@wojtek-t @matthyx @k8s-ci-robot @HirazawaUi