Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: increase ut converage for config/upgradeconfiguration #123842

Merged
merged 1 commit into from
Apr 18, 2024
Merged

kubeadm: increase ut converage for config/upgradeconfiguration #123842

merged 1 commit into from
Apr 18, 2024

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Mar 10, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

kubeadm: increase ut converage for config/upgradeconfiguration

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 10, 2024
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 10, 2024
neolit123
neolit123 reviewed Mar 10, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @my-git9
added some comments

cmd/kubeadm/app/util/config/upgradeconfiguration_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/config/upgradeconfiguration_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/config/upgradeconfiguration_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/config/upgradeconfiguration_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/config/upgradeconfiguration_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/config/upgradeconfiguration_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/config/upgradeconfiguration_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/config/upgradeconfiguration_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/config/upgradeconfiguration_test.go Outdated Show resolved Hide resolved
@neolit123
Copy link
Member

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 10, 2024
@my-git9
kubeadm: increase ut converage for config/upgradeconfiguration
a4fe397 
Signed-off-by: xin.li <xin.li@daocloud.io>
@my-git9 my-git9 requested a review from neolit123 March 11, 2024 11:05
neolit123
neolit123 reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

we are in code freeze for 1.30, so this can merge automatically after the code freeze is lifted.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8993432d0dc079c471557b8ff28c7d8fb9a611e3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: my-git9, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit ab91dd6 into kubernetes:master Apr 18, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@chendave chendave Awaiting requested review from chendave

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
3 participants
@my-git9 @neolit123 @k8s-ci-robot