Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial logrotate support. #1234

Merged
merged 1 commit into from
Sep 9, 2014
Merged

Conversation

brendandburns
Copy link
Contributor

@smarterclayton @derekwaynecarr please verify for red hat / vagrant support

Thanks!
--brendan

@smarterclayton
Copy link
Contributor

I believe the journal should handle most of it automatically - however will let derek or @eparis comment

@derekwaynecarr
Copy link
Member

@brendandburns - i tried this out and was able to provision the vagrant setup fine.

I am not familiar with the advantages of logrotate over systemd journald command, my cursory examination shows there is overlap in use case, but I see no reason to hold this up.

LGTM

@brendandburns
Copy link
Contributor Author

@derekwaynecarr thanks for the review! I chose logrotate because I could install it onto debian, without changing over init.d etc to use systemd...

--brendan

@smarterclayton
Copy link
Contributor

Yeah, on a systemd system you shouldn't need log rotate for any service that is logging to stdout via the unit.

@brendandburns brendandburns added this to the v0.5 milestone Sep 9, 2014
@brendandburns
Copy link
Contributor Author

ok, @jbeda I updated this. ptal.

Thanks!
--brendan

@jbeda
Copy link
Contributor

jbeda commented Sep 9, 2014

We'll just have to remember to update this if we add new binaries. Merging.

jbeda added a commit that referenced this pull request Sep 9, 2014
Add initial logrotate support.
@jbeda jbeda merged commit 732b7ce into kubernetes:master Sep 9, 2014
josefkarasek pushed a commit to josefkarasek/kubernetes that referenced this pull request May 5, 2022
…lang-update

[release-4.7][ART-3664] Bug 2043804: IPs with leading zeros are still valid in the apiserver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants