Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri-api: KEP-3857: Recursive Read-only (RRO) mounts [Split from #123180 for ease of review] #123272

Merged
merged 1 commit into from
Feb 16, 2024
Merged

cri-api: KEP-3857: Recursive Read-only (RRO) mounts [Split from #123180 for ease of review] #123272

merged 1 commit into from
Feb 16, 2024
+1,045 −469

Conversation

AkihiroSuda
Copy link
Member

Note

This PR was split from #123180 for ease of review and merge.
See #123180 for the entire implementation.

Depended by:

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Update the CRI API for KEP-3857: Recursive Read-only (RRO) mounts: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/3857-rro-mounts

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

cri-api: KEP-3857: Recursive Read-only (RRO) mounts

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://kep.k8s.io/3857
- [Implementation]: https://github.com/kubernetes/kubernetes/pull/123180

@AkihiroSuda
cri-api: KEP-3857: Recursive Read-only (RRO) mounts
a834bd8 
This commit modifies the following files:

- `staging/src/k8s.io/cri-api/pkg/apis/runtime/v1/api.proto`
- `staging/src/k8s.io/cri-api/pkg/errors/errors.go`

Other changes were auto-generated by running `make update`.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 13, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 13, 2024
@AkihiroSuda AkihiroSuda mentioned this pull request Feb 13, 2024
Merged
2 tasks
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 13, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@AkihiroSuda
Copy link
Member Author

/label api-review

(Already reviewed in kubernetes/enhancements#3858 though)

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Feb 13, 2024
@dims
Copy link
Member

dims commented Feb 16, 2024

/assign @derekwaynecarr @mrunalp @dchen1107

@haircommander
Copy link
Contributor

/approve
LGTM. Note, if we take a moment to merge this, we'll have to coordinate with #123216 but this is pretty straight forward so I think we can do this one first

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2024
@rata
Copy link
Member

rata commented Feb 16, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d18c2bbb0043e853f509d5a39aa900083e6c11e8

@k8s-ci-robot k8s-ci-robot merged commit e430031 into kubernetes:master Feb 16, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 16, 2024
This was referenced Feb 17, 2024
Merged
Merged
Open
@liggitt liggitt removed the api-review Categorizes an issue or PR as actively needing an API review. label Feb 22, 2024
@kwilczynski kwilczynski mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh Awaiting requested review from bart0sh

@rphillips rphillips Awaiting requested review from rphillips

Assignees

@mrunalp mrunalp

@rata rata

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
10 participants
@AkihiroSuda @k8s-ci-robot @k8s-triage-robot @dims @haircommander @rata @mrunalp @liggitt @derekwaynecarr @dchen1107