Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evented pleg mirror pod & use IsEventedPLEGInUse instead of FG status check #122778

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix evented pleg mirror pod & use IsEventedPLEGInUse instead of FG status check #122778

wants to merge 7 commits into from

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 15, 2024 •
edited
Loading

This PR is based on #122763, and we use IsEventedPLEGInUse() instead of utilfeature.DefaultFeatureGate.Enabled(features.EventedPLEG).

Fixes #123087

Context can be found in #122763.

kubelet: fix a static pod startup bug with Evented PLEG

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 15, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Jan 15, 2024

/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-alpha-features
/test pull-kubernetes-e2e-kind-beta-features

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 15, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Jan 15, 2024

/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-alpha-features

@pacoxu
Copy link
Member Author

pacoxu commented Jan 15, 2024

/test pull-kubernetes-unit
/test pull-kubernetes-integration

@pacoxu
Copy link
Member Author

pacoxu commented Jan 15, 2024

/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-alpha-features

2 similar comments
@pacoxu
Copy link
Member Author

pacoxu commented Jan 15, 2024

/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-alpha-features

@pacoxu
Copy link
Member Author

pacoxu commented Jan 15, 2024

/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-alpha-features

@pacoxu pacoxu marked this pull request as ready for review January 15, 2024 08:41
@pacoxu
Copy link
Member Author

pacoxu commented Jan 15, 2024

/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-alpha-features

1 similar comment
@pacoxu
Copy link
Member Author

pacoxu commented Jan 15, 2024

/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-alpha-features

@pacoxu

This comment was marked as duplicate.

Sign in to view
1 similar comment
@pacoxu

This comment was marked as duplicate.

Sign in to view
@pacoxu pacoxu force-pushed the fix-evented-pleg-mirro-pod-3 branch from 6b4962c to 8775606 Compare October 31, 2024 03:26
@pacoxu
Copy link
Member Author

pacoxu commented Oct 31, 2024

/test pull-kubernetes-node-e2e-cri-proxy-serial

@pacoxu pacoxu marked this pull request as draft October 31, 2024 09:10
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2024
@pacoxu pacoxu force-pushed the fix-evented-pleg-mirro-pod-3 branch from 8775606 to 8aa4d9c Compare October 31, 2024 09:10
@pacoxu
Copy link
Member Author

pacoxu commented Nov 1, 2024

/test pull-kubernetes-node-e2e-cri-proxy-serial

@pacoxu pacoxu force-pushed the fix-evented-pleg-mirro-pod-3 branch 2 times, most recently from 002e29f to adb9a2d Compare November 1, 2024 05:19
@pacoxu
Copy link
Member Author

pacoxu commented Nov 1, 2024

/test pull-kubernetes-node-e2e-cri-proxy-serial

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2024
@pacoxu pacoxu force-pushed the fix-evented-pleg-mirro-pod-3 branch from adb9a2d to 54c5b3c Compare December 3, 2024 03:51
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pacoxu
Once this PR has been reviewed and has the lgtm label, please ask for approval from smarterclayton. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu pacoxu marked this pull request as ready for review December 3, 2024 03:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Dec 3, 2024

/test pull-kubernetes-node-e2e-containerd-alpha-features
/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha
/test pull-crio-cgroupv1-node-e2e-eviction
/test pull-crio-cgroupv2-node-e2e-eviction
/test pull-kubernetes-node-e2e-cri-proxy-serial

/test pull-kubernetes-e2e-kind-beta-features
/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-alpha-features
/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e

pacoxu and others added 7 commits December 6, 2024 16:49
@pacoxu
for CREATED state, skip if EventedPLEG is enabled
0cfd156
@pacoxu
fix eventedPLEG flake: init container may waiting with empty reason b…
aece0b9 
…efore seeting it to PodInitializing
@pacoxu
add log for whether trigger start/restart for Created state
90438f7
@pacoxu
use IsEventedPLEGInUse instead of check FG status
ba28c48
@pacoxu
restart with a time check for evented pleg: default 1m
ad8bc71
@pacoxu
restart sidecar container like static pod created state container
ed18e05
@hshiina @pacoxu
EventedPLEG: Update global cache timestamp more frequently
c530f9c 
This fix makes the period to update the global cache timestamp for
Evented PLEG shorter in order to unblock pod workers that get stuck
in `cache.GetNewerThan()` as fast as Generic PLEG. Before updating the
global timestamp, this fix calls Version() CRI API in order to confirm
there is no problem with communicating with the runtime. By this, we
can assume pods that have not been receiving events are in the latest
status.
@pacoxu pacoxu force-pushed the fix-evented-pleg-mirro-pod-3 branch from 54c5b3c to c530f9c Compare December 6, 2024 08:50
@pacoxu
Copy link
Member Author

pacoxu commented Dec 6, 2024

/test pull-kubernetes-node-e2e-containerd-alpha-features
/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha
/test pull-crio-cgroupv1-node-e2e-eviction
/test pull-crio-cgroupv2-node-e2e-eviction
/test pull-kubernetes-node-e2e-cri-proxy-serial

/test pull-kubernetes-e2e-kind-beta-features
/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-alpha-features
/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e

/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e-kubetest2

@HirazawaUi HirazawaUi mentioned this pull request Jan 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxx213 wxx213 wxx213 left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mrunalp mrunalp Awaiting requested review from mrunalp

@odinuge odinuge Awaiting requested review from odinuge

@tallclair tallclair Awaiting requested review from tallclair

@aojea aojea Awaiting requested review from aojea

@sairameshv sairameshv Awaiting requested review from sairameshv

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@mikebrow mikebrow Awaiting requested review from mikebrow

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@harche harche Awaiting requested review from harche

@yujuhong yujuhong Awaiting requested review from yujuhong

@tzneal tzneal Awaiting requested review from tzneal

@wzshiming wzshiming Awaiting requested review from wzshiming

Assignees

@smarterclayton smarterclayton

@yujuhong yujuhong

@harche harche

Labels
area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: PRs Waiting on Author
SIG Node: code and documentation PRs
Status: Waiting on Author
[sig-release] Bug Triage
Status: Release Blocker
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubelet started multi-containers for static pods when EventedPLEG is enabled