Fix up dockerized build and release build #1221
Conversation
|
Will look into it. |
* Support cleaning out built docker images * Use bash arrays in places * Lock etcd version we are testing against
jbeda
force-pushed
the
dockerized-deploy
branch
from
5df9e73 to
d03a55a
Compare
|
@filbranden Please take another look. I went through and fixed a bunch of names to match the style guide. I'm sure I still missed some stuff but it should be better. |
| cp build/build-image/Dockerfile ${BUILD_CONTEXT_DIR}/Dockerfile | ||
| docker-build "${KUBE_BUILD_IMAGE}" "${BUILD_CONTEXT_DIR}" | ||
| ) | ||
| mkdir -p ${build_context_dir} |
There was a problem hiding this comment.
These occurrences of ${build_context_dir} in this line and the four that follow it should be in double quotes.
jbeda
force-pushed
the
dockerized-deploy
branch
from
d03a55a to
ed5bfa2
Compare
|
Please take another look. I'm happy to eliminate code duplication after hack settles. |
|
Looks good, thanks for addressing my remarks! Yep, let's merge it in and figure out how to converge in the future. I really wish our build frameworks would become more generic. From glancing at this, it looks like a lot of it is very specific to building inside Docker but I think we could target other interesting cases (I looked into having Travis do our build and push the binaries to GitHub, for instance.) We can try to refactor that in the future... Also, at this point I'm fairly convinced shell isn't scaling for what this is trying to do... Maybe we should have a closer look at that Cheers, |
Fix up dockerized build and release build
[release-4.10] Bug 2065774: Backport 108723 OutofCpu Fixes
This is still WIP but I wanted to get this stuff in so that this is reviewed in more bite sized chunks.