Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime handler field to ImageSpec struct #121121

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Add runtime handler field to ImageSpec struct #121121

merged 2 commits into from
Oct 17, 2023
+491 −423

Conversation

kiashok
Copy link
Contributor

@kiashok kiashok commented Oct 10, 2023 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR brings in CRI changes needed for KEP 4216 .
New runtime handler field is added to ImageSpec struct

Which issue(s) this PR fixes:

Addresses CRI changes needed for KEP 4216

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No

CRI: support image pull per runtime class

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP 4126]: https://github.com/kubernetes/enhancements/pull/4217/commits/51df9e2d2bc391e43000da7221a4955fcaa82012

@kiashok
Add runtime handler field to ImageSpec
5de835d 
Will be used by changes for image pull per runtime class in KEP 4216

Signed-off-by: kiashok <kiashok@microsoft.com>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @kiashok. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 10, 2023
@kiashok
Copy link
Contributor Author

kiashok commented Oct 10, 2023

cc @jsturtevant @marosset @aravindhp @mikebrow @mrunalp @haircommander

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 10, 2023
@jsturtevant
Copy link
Contributor

/ok-to-test
/sig windows
/sig node

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2023
@jsturtevant
Copy link
Contributor

/triage accepted
/priority important-soon
/milestone v1.29

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 10, 2023
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 10, 2023
@kiashok kiashok mentioned this pull request Oct 10, 2023
Closed
9 tasks
@jsturtevant
Copy link
Contributor

/retest

@jsturtevant
Copy link
Contributor

/lgtm
/assign @mrunalp @SergeyKanzhelev

@kiashok
Copy link
Contributor Author

kiashok commented Oct 13, 2023

/lgtm /assign @mrunalp @SergeyKanzhelev

@mrunalp @SergeyKanzhelev could you take a look at this PR when you have some time please?

@pacoxu pacoxu mentioned this pull request Oct 16, 2023
Closed
4 tasks
@pacoxu
Copy link
Member

pacoxu commented Oct 16, 2023

/assign @haircommander @mikebrow

@pacoxu
Copy link
Member

pacoxu commented Oct 16, 2023

/release-note-edit

CRI: support image pull per runtime class

Would you update the CRI-API changelog https://github.com/kubernetes/kubernetes/blob/afc302c2d24fea7be7d6af33c79fdb81e1a33131/staging/src/k8s.io/cri-api/README.md#change-history?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 16, 2023
@kiashok
Update cri-api change in v1.29.0
d1a6c0a 
Signed-off-by: kiashok <kiashok@microsoft.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@kiashok
Copy link
Contributor Author

kiashok commented Oct 16, 2023

/release-note-edit

CRI: support image pull per runtime class

Would you update the CRI-API changelog https://github.com/kubernetes/kubernetes/blob/afc302c2d24fea7be7d6af33c79fdb81e1a33131/staging/src/k8s.io/cri-api/README.md#change-history?

update the PR with this change.

@haircommander haircommander mentioned this pull request Oct 16, 2023
Closed
@haircommander
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 22b08bda926d72ac5e8d58501ed80a7d276cc069

mikebrow
mikebrow approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hailkomputer
Copy link
Member

Hello! Bug triage team lead here. I want to check the status.
The code freeze is starting 01:00 UTC Wednesday 1st November 2023 / 18:00 PDT Tuesday 31st October 2023 (about two weeks from now), and while there is still plenty of time, we want to ensure that each PR has a chance to be merged and issues are addressed on time.
As the PR is tatargeting 1.29, is it still planned for this release?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kiashok, mikebrow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5b7339b into kubernetes:master Oct 17, 2023
@kiashok kiashok mentioned this pull request Oct 24, 2023
Merged
@sftim
Copy link
Contributor

sftim commented Nov 22, 2023

Changelog suggestion

CRI: Added support for pulling container images per runtime class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebrow mikebrow mikebrow approved these changes

@haircommander haircommander haircommander approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mrunalp mrunalp

@jsturtevant jsturtevant

@haircommander haircommander

@SergeyKanzhelev SergeyKanzhelev

@mikebrow mikebrow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
[sig-release] Bug Triage
Archived in project
[sig-windows] PR tracking
Status: Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
10 participants
@kiashok @k8s-ci-robot @jsturtevant @pacoxu @haircommander @hailkomputer @sftim @mikebrow @mrunalp @SergeyKanzhelev