Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet disk api cri update #120914

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Kubelet disk api cri update #120914

merged 1 commit into from
Oct 24, 2023

Conversation

kannon92
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

As part of Split Image Filesystem KEP, we will update CRI with our KEP design.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add container filesystem to the ImageFsInfoResponse.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/issues/4191

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 27, 2023
@kannon92 kannon92 force-pushed the kubelet-disk-api-cri-update branch from 87cb191 to da186e3 Compare September 27, 2023 19:25
@kannon92
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 27, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet and removed do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels Sep 27, 2023
@kannon92
Copy link
Contributor Author

/retest

@kannon92 kannon92 force-pushed the kubelet-disk-api-cri-update branch from da186e3 to a2fa628 Compare September 27, 2023 21:09
@kannon92
Copy link
Contributor Author

/retest

1 similar comment
@kannon92
Copy link
Contributor Author

/retest

@bart0sh
Copy link
Contributor

bart0sh commented Sep 28, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 28, 2023
@kannon92 kannon92 force-pushed the kubelet-disk-api-cri-update branch from a2fa628 to dc44935 Compare September 29, 2023 18:23
kannon92
kannon92 commented Oct 17, 2023
View reviewed changes
pkg/kubelet/cri/remote/remote_image.go
// ImageFsInfo returns information of the filesystem that is used to store images.
func (r *remoteImageService) ImageFsInfoV2(ctx context.Context) (*runtimeapi.ImageFsInfoResponse, error) {
// Do not set timeout, because `ImageFsInfo` takes time.
// TODO(random-liu): Should we assume runtime should cache the result, and set timeout here?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied these TODO from the previous one but I don't really know if these will ever be valid. Left them in for now.

@kannon92 kannon92 force-pushed the kubelet-disk-api-cri-update branch from d01341a to 229387e Compare October 18, 2023 20:50
@kannon92
Copy link
Contributor Author

/retest

@kannon92 kannon92 force-pushed the kubelet-disk-api-cri-update branch 2 times, most recently from bd2dbad to c1a1f85 Compare October 22, 2023 17:58
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 22, 2023
@kannon92
Copy link
Contributor Author

/cc @ffromani

@k8s-ci-robot k8s-ci-robot requested a review from ffromani October 23, 2023 11:43
@kannon92 kannon92 force-pushed the kubelet-disk-api-cri-update branch from c1a1f85 to c078bee Compare October 23, 2023 14:07
mikebrow
mikebrow reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits

staging/src/k8s.io/cri-api/pkg/apis/runtime/v1/api.proto Outdated Show resolved Hide resolved
staging/src/k8s.io/cri-api/pkg/apis/services.go Outdated Show resolved Hide resolved
@kannon92 kannon92 force-pushed the kubelet-disk-api-cri-update branch from e8986cf to 94ff9cf Compare October 23, 2023 18:03
@kannon92 @mikebrow
add container filesystem to CRI api
8ae0d39 
Co-authored-by: Mike Brown <brownwm@us.ibm.com>
@kannon92 kannon92 force-pushed the kubelet-disk-api-cri-update branch from 94ff9cf to 8ae0d39 Compare October 23, 2023 19:04
@kannon92
Copy link
Contributor Author

/retest

@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 26e8c914195f0ab6b4ce6a4696c49977aec1d154

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 413b15a into kubernetes:master Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 24, 2023
@aojea
Copy link
Member

aojea commented Oct 31, 2023

We should not merge API changes and implementation separately, basically because we can not test it and we can not predice they are not going to be changes during the implementation ...

This was referenced Oct 25, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebrow mikebrow mikebrow left review comments

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@rphillips rphillips Awaiting requested review from rphillips

@haircommander haircommander Awaiting requested review from haircommander

@ffromani ffromani Awaiting requested review from ffromani

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
8 participants
@kannon92 @bart0sh @haircommander @k8s-ci-robot @aojea @rphillips @mrunalp @mikebrow