Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rules to switch from deprecated dir field #120822

Merged
merged 2 commits into from
Oct 4, 2023
Merged

update rules to switch from deprecated dir field #120822

merged 2 commits into from
Oct 4, 2023

Conversation

akhilerm
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

dir field has been deprecated in favour of dirs field, so that multiple directories can be specified in the rules in future
when publishing-bot moves from filter-branch to filter-repo. The change was introduced in publishing bot in kubernetes/publishing-bot#337

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This change will be made to the rules file, next time update-rules command will be run for adding branch / go version upgrade. Making this change now so that, the diff is smaller and review becomes easier. Even without this update the bot will continue to function as is. But making sure that the deprecated fields are not used anywhere.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@akhilerm
update rules to switch from deprecated dir field
45a776d 
dir field has been deprecated in favour of dirs field, so that
multiple directories can be specified in the rules in future
when publishing-bot moves from filter-branch to filter-repo

Signed-off-by: Akhil Mohan <makhil@vmware.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 22, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 22, 2023
@akhilerm
Copy link
Member Author

/cc @nikhita

@akhilerm
update verify script to check deprecated fields
2ce4f85 
Signed-off-by: Akhil Mohan <makhil@vmware.com>
@ameukam
Copy link
Member

ameukam commented Sep 29, 2023

cc @kubernetes/release-engineering

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d715cf2e2a27987b3bcb1a04143a4ba85a967364

nikhita
nikhita approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@akhilerm
Copy link
Member Author

akhilerm commented Oct 4, 2023

/assign @dims
For update on the publishing-bot verify script.

@dims
Copy link
Member

dims commented Oct 4, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
xmudrii
xmudrii approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhilerm, dims, nikhita, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 56f3304 into kubernetes:master Oct 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 4, 2023
@akhilerm akhilerm deleted the change-from-deprecated-fields branch October 4, 2023 12:31
This was referenced Oct 5, 2023
Merged
Closed
@akhilerm akhilerm mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@nikhita nikhita nikhita approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@dims dims Awaiting requested review from dims

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@dims dims

@ameukam ameukam

@nikhita nikhita

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
7 participants
@akhilerm @k8s-ci-robot @ameukam @dims @saschagrunert @nikhita @xmudrii