Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GAed feature gates SeccompDefault/TopologyManager/OpenAPIV3/Se… #120261

Closed
wants to merge 1 commit into from
Closed

Remove GAed feature gates SeccompDefault/TopologyManager/OpenAPIV3/Se… #120261

wants to merge 1 commit into from

Conversation

tukwila
Copy link
Contributor

@tukwila tukwila commented Aug 30, 2023

…rverSideApply/ServerSideFieldValidation

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

All of these feature gates have been GAed, and can be removed since v1.29:

  • SeccompDefault
  • TopologyManager
  • OpenAPIV3
  • ServerSideApply
  • ServerSideFieldValidation

Which issue(s) this PR fixes:

Fixes # None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 30, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @tukwila. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 30, 2023
@pacoxu
Copy link
Member

pacoxu commented Sep 5, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2023
@tukwila
Copy link
Contributor Author

tukwila commented Sep 5, 2023

@saschagrunert could you please look at this PR that i plan to remove SeccompDefault from GA?
@lmdaly @swatisehgal please look at this PR as well?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2023
@tukwila tukwila force-pushed the featuregate-cleanup branch from 7396e12 to c1b50a5 Compare September 5, 2023 06:51
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 5, 2023
@tukwila tukwila force-pushed the featuregate-cleanup branch 2 times, most recently from cf88e5f to 2861ead Compare September 5, 2023 07:48
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saschagrunert, tukwila
Once this PR has been reviewed and has the lgtm label, please assign jpbetz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tukwila tukwila force-pushed the featuregate-cleanup branch from accbeaa to f2d9900 Compare September 5, 2023 08:33
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2023
liggitt
liggitt reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple comments on the test removals

in general, it's better to have one PR drop one feature gate (or related set of feature gates), since those relate to different SIGs

@logicalhan @jpbetz, what are your thoughts about continuing to drop feature gates on schedule, knowing there's a desire to track them past GA in the future? The code these gate was already ungated when they got promoted to GA, so I don't think we're losing much here

test/integration/apiserver/openapi/openapi_merge_test.go Show resolved Hide resolved
test/integration/apiserver/openapi/openapiv3_test.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Sep 5, 2023
@tukwila tukwila force-pushed the featuregate-cleanup branch from b75f649 to 37ea850 Compare September 5, 2023 14:07
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Sep 5, 2023
@tukwila tukwila force-pushed the featuregate-cleanup branch from 2ff35d1 to dd3eec2 Compare September 5, 2023 14:10
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 5, 2023
@tukwila tukwila force-pushed the featuregate-cleanup branch 2 times, most recently from 954b8f8 to dfe533e Compare September 5, 2023 14:40
@tukwila tukwila requested a review from liggitt September 5, 2023 14:41
@tukwila tukwila force-pushed the featuregate-cleanup branch 2 times, most recently from c8c809a to 6a4dc16 Compare September 5, 2023 23:43
@tukwila
Remove GAed feature gates SeccompDefault/TopologyManager/OpenAPIV3/Se…
dc58b30 
…rverSideApply/ServerSideFieldValidation

Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
@tukwila tukwila force-pushed the featuregate-cleanup branch from 25799f6 to dc58b30 Compare September 6, 2023 07:17
@pacoxu
Copy link
Member

pacoxu commented Sep 6, 2023

/test pull-kubernetes-node-e2e-containerd

@tukwila
Copy link
Contributor Author

tukwila commented Sep 6, 2023

/test pull-kubernetes-e2e-gce-cos-alpha-features

@pacoxu
Copy link
Member

pacoxu commented Sep 7, 2023

Overall LGTM.

@logicalhan @jpbetz, what are your thoughts about continuing to drop feature gates on schedule, knowing there's a desire to track them past GA in the future? The code these gate was already ungated when they got promoted to GA, so I don't think we're losing much here

Pending on feature owners and Jordon's comment.

@jiahuif
Copy link
Member

jiahuif commented Sep 7, 2023

/assign @logicalhan @jpbetz
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tukwila tukwila mentioned this pull request Oct 17, 2023
Merged
@dims dims added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 24, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@jpbetz jpbetz

@logicalhan logicalhan

Labels
area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tukwila @k8s-ci-robot @pacoxu @jiahuif @k8s-triage-robot @saschagrunert @liggitt @dims @jpbetz @logicalhan