-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please expedite: the rarely attempted interface{} -> runtime.Object rename #1202
Conversation
3031597
to
cdca8fa
Compare
…for types of those names
835e9b3
to
1d431ce
Compare
@smarterclayton @brendandburns @thockin @dchen1107: If you guys could avoid merging too much stuff before going through this one, that will make my life easier. I don't want to rebase this any more than absolutely necessary... |
Other than that concern, rest of it looks fine and I'll be able to give a LGTM |
@smarterclayton We could (in the future) make the method useful, like it could return an interface to the JSONBase and let us get rid of all the ResourceVersioner weirdness. That's a simple find-and-replace operation after this PR, so I'd rather get this in and then debate it. |
Ok, then next question - can you make this a method on JSONBase instead so you don't need to define it on all the other objects (since JSONBase is embedded)? |
@smarterclayton Wouldn't that be nice. Unfortunately, I tried it and that has the effect of forcing not a pointer. There's no way to force pointer on the object you're embedded in by adding a method on a thing that gets embedded. :( :( |
The wailing and gnashing of teeth.... ok, LGTM. In the future would like to make the method more meaningful and its presence less odious. |
Please expedite: the rarely attempted interface{} -> runtime.Object rename
@smarterclayton Thanks for the quick feedback. Self-merging to avoid rebase hell. |
No description provided.