ScheduledJob controller proposal #11980

soltysh · 2015-07-29T14:54:44Z

Diverged from #11746.

// cc @smarterclayton @timothysc @pmorie @bgrant0607 @davidopp @nwendling @derekwaynecarr @erictune @mikedanese @thockin

k8s-bot · 2015-07-29T14:55:08Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

timothysc · 2015-07-31T16:41:35Z

docs/proposals/scheduledjob.md

@@ -0,0 +1,132 @@
+# ScheduledJob Controller


Comment still holds on name

The problem with "Cron" is that is technically focused (a particular linux
tool) but is opaque to higher level users who come from different
backgrounds.

Even the Chronos GitHub page describes it with "It allows you to schedule
your jobs using ISO8601 repeating interval notation, which enables more
flexibility in job scheduling". RepeatingJob or CalendarJob or
RecurringJob all seem less clear to an outside user (someone who is not an
expert at these systems) than ScheduledJob.

On Fri, Jul 31, 2015 at 12:41 PM, Timothy St. Clair <
notifications@github.com> wrote:

In docs/proposals/scheduledjob.md
#11980 (comment)
:

@@ -0,0 +1,132 @@
+# ScheduledJob Controller

Comment still holds on name

—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/11980/files#r35991090
.

Clayton Coleman | Lead Engineer, OpenShift

Proposal was around (diurnal, periodic, etc.) There may be a couple more.

Periodic suffers some of the same usability concerns. I do think API
objects should be precise in their meaning, but designed for end users, not
systems researchers.

On Fri, Jul 31, 2015 at 1:02 PM, Timothy St. Clair <notifications@github.com

wrote:

In docs/proposals/scheduledjob.md
#11980 (comment)
:

@@ -0,0 +1,132 @@
+# ScheduledJob Controller

Proposal was around (diurnal, periodic, etc.) There may be a couple more.

—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/11980/files#r35992880
.

Clayton Coleman | Lead Engineer, OpenShift

I'm fine with ScheduledJob. It's similar to ScheduledExecutorService in Java.

Could also call it CalendaredJob

erictune · 2015-08-05T23:17:49Z

When you implement this please put in expapi. (#12001).

soltysh · 2015-08-11T11:38:15Z

@erictune gotcha.

bgrant0607 · 2015-08-11T16:18:02Z

docs/proposals/scheduledjob.md

+type ScheduledJobStatus struct {
+
+    // PendingExecutions are the job runs pending for execution
+    PendingExecutions []Job


Much of the same feedback applies to this API as to Job.

Yeah, I'll address them as soon as we have consensus on Job API, which I'm hoping will happen withing next couple of days :)

My feedback re: Job API and overall status applies here too.

soltysh · 2015-08-18T12:53:55Z

@bgrant0607 @erictune I've updated the proposal, cutting the status structure significantly. I've only left there a list of currently executing jobs, which is needed to track these executions and fulfill the defined ConcurrentPolicy.

soltysh · 2015-08-18T12:54:09Z

@derekwaynecarr @smarterclayton ptal as well

mikedanese · 2015-08-18T15:45:55Z

docs/proposals/scheduledjob.md

+type ScheduledJobStatus struct {
+
+    // Jobs are the currently running instances of a ScheduledJob.
+    Jobs []Job


Why not a selector query? (you'd have to add a selector to ScheduledJobSpec)

How would you differentiate concurrent runs? We'd have to generate some random uuid for that selector in that case.

The selector should select all Jobs created by the ScheduledJob. We can sort them by CreationTimestamp. What do you mean differentiate? How does having an array help you differentiate?

Yeah, I haven't thought about sorting them by CreationTimestamp, which generally speaking allows me to distinguish (that's the word I've meant to use, sorry :/) different ScheduledJob executions/runs needed to properly handle ConcurrentPolicy.

Sorting by CreationTimestamp seems exactly what the user would want, since ScheduledJobs are launched based on time.

Please no array.

Array removed, added selector to ScheduledJobSpec.

bgrant0607 · 2015-08-25T04:09:51Z

docs/proposals/scheduledjob.md

+    Jobs []Job
+
+    // Successful tracks the overall amount of successful completions of this job.
+    Successful int


If these accumulate indefinitely, they should probably be int64.

soltysh · 2015-08-25T12:47:56Z

@mikedanese @bgrant0607 addressed your comments, appreciate another round of reviews.

k8s-bot · 2015-08-25T13:07:12Z

GCE e2e build/test passed for commit e234d1f91b25a3bb16d4412459cd761416a2b248.

k8s-github-robot · 2015-08-27T22:29:45Z

Labelling this PR as size/L

mikedanese · 2015-09-17T19:27:16Z

Let's continue this review targeting v1.2

erictune · 2016-01-13T16:11:53Z

@bgrant0607 wonder if you have an opinion on the ScheduledJobSpec.UniqueLabelKey approach in this PR, versus having the unique selector generation be part of Job itself.

bgrant0607 · 2016-01-13T16:12:55Z

@erictune I'd prefer unique label/selector generation to be part of Job.

soltysh · 2016-01-14T11:12:08Z

@erictune as requested:

removed pointer from Active
made JobTemplate pointer
made JobTemplate be JobTemplateSpec type
moved label generation to job (new section about JobSpec modifications)

I've also:

fixed all the ISO8601 leftovers
extended future evolution with proper links to workflow and templating

It's all squashed and waiting your sing-off.

k8s-bot · 2016-01-14T11:42:18Z

GCE e2e test build/test passed for commit 10de4c2.

erictune · 2016-01-16T00:30:40Z

This looks great. LGTM.

soltysh · 2016-01-16T06:35:19Z

Thanks for your help!

alex-mohr · 2016-01-21T16:51:20Z

@k8s-bot unit test this

soltysh · 2016-01-25T16:30:14Z

@erictune any chance on having this one merged?

erictune · 2016-01-25T16:39:13Z

Merging because this is just a new doc. Build failure is known flaky test.

ScheduledJob controller proposal

erictune · 2016-01-25T16:39:30Z

@soltysh merged.

soltysh · 2016-01-25T17:46:44Z

@erictune thank you!

yuvipanda · 2016-02-27T02:24:58Z

Is this being implemented anywhere?

soltysh · 2016-02-27T06:48:58Z

Not yet. I'm planning to start working on it after 1.2 is released.
On Feb 27, 2016 3:25 AM, "Yuvi Panda" notifications@github.com wrote:

Is this being implemented anywhere?

—
Reply to this email directly or view it on GitHub
#11980 (comment)
.

haizaar · 2016-03-25T21:28:12Z

Jobs guide says that "cron is expected in the next minor release". Do you plan this for 1.3 or 1.2.x?

erictune · 2016-03-25T21:37:44Z

1.3

zacharynevin · 2016-04-26T08:36:42Z

What is the projected release date for v1.3?

sdminonne · 2016-04-26T08:40:42Z

@zacharynevin see https://github.com/kubernetes/kubernetes/wiki/Release-1.3

wernight · 2016-10-11T19:55:25Z

Looks like documentation on http://kubernetes.io/docs/user-guide/jobs/#future-work didn't get updated (still pointing here). Should probably contain some of http://kubernetes.io/docs/user-guide/scheduled-jobs/

Also the reference documentation seems outdated http://kubernetes.io/docs/api-reference/batch/v1/definitions/

Last, but not least, the example on http://kubernetes.io/docs/user-guide/scheduled-jobs/#writing-a-scheduled-job-spec uses two non-standard notations: ? and 0/1 (not */1) which are not explained.

…ler_proposal ScheduledJob controller proposal

googlebot added the cla: yes label Jul 29, 2015

soltysh mentioned this pull request Jul 29, 2015

Job controller proposal #11746

Merged

mikedanese assigned davidopp Jul 29, 2015

bgrant0607 added the area/api Indicates an issue on api area. label Jul 30, 2015

timothysc reviewed Jul 31, 2015
View reviewed changes

bgrant0607 reviewed Aug 11, 2015
View reviewed changes

soltysh force-pushed the scheduledjob_controller_proposal branch from 463be2b to 15a69e4 Compare August 18, 2015 12:51

mikedanese reviewed Aug 18, 2015
View reviewed changes

davidopp assigned mikedanese and unassigned davidopp Aug 18, 2015

davidopp mentioned this pull request Aug 22, 2015

Distributed CRON jobs in k8s #2156

Closed

bgrant0607 reviewed Aug 25, 2015
View reviewed changes

soltysh force-pushed the scheduledjob_controller_proposal branch from 15a69e4 to e234d1f Compare August 25, 2015 12:43

k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2015

soltysh mentioned this pull request Sep 1, 2015

Carry our own webhooks implementation openshift/origin#4426

Merged

eparis mentioned this pull request Sep 12, 2015

githubmunger: label PRs based on certain files touched kubernetes-retired/contrib#79

Closed

ScheduledJob controller proposal

10de4c2

soltysh force-pushed the scheduledjob_controller_proposal branch from b00be17 to 10de4c2 Compare January 14, 2016 11:10

erictune added e2e-not-required lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 16, 2016

erictune added a commit that referenced this pull request Jan 25, 2016

Merge pull request #11980 from soltysh/scheduledjob_controller_proposal

99f301d

ScheduledJob controller proposal

erictune merged commit 99f301d into kubernetes:master Jan 25, 2016

soltysh deleted the scheduledjob_controller_proposal branch January 26, 2016 08:37

soltysh mentioned this pull request Apr 29, 2016

Scheduledjob api #24970

Merged

philips mentioned this pull request May 18, 2016

ScheduledJob client #25475

Merged

soltysh mentioned this pull request Oct 12, 2016

Issues with ScheduledJob docs kubernetes/website#1439

Closed

xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016

Merge pull request kubernetes#11980 from soltysh/scheduledjob_control…

b78a52f

…ler_proposal ScheduledJob controller proposal

ScheduledJob controller proposal #11980

ScheduledJob controller proposal #11980

Conversation

soltysh commented Jul 29, 2015

k8s-bot commented Jul 29, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erictune commented Aug 5, 2015

soltysh commented Aug 11, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soltysh commented Aug 18, 2015

soltysh commented Aug 18, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soltysh commented Aug 25, 2015

k8s-bot commented Aug 25, 2015

k8s-github-robot commented Aug 27, 2015

mikedanese commented Sep 17, 2015

erictune commented Jan 13, 2016

bgrant0607 commented Jan 13, 2016

soltysh commented Jan 14, 2016

k8s-bot commented Jan 14, 2016

erictune commented Jan 16, 2016

soltysh commented Jan 16, 2016

alex-mohr commented Jan 21, 2016

soltysh commented Jan 25, 2016

erictune commented Jan 25, 2016

erictune commented Jan 25, 2016

soltysh commented Jan 25, 2016

yuvipanda commented Feb 27, 2016

soltysh commented Feb 27, 2016

haizaar commented Mar 25, 2016

erictune commented Mar 25, 2016

zacharynevin commented Apr 26, 2016

sdminonne commented Apr 26, 2016

wernight commented Oct 11, 2016 • edited Loading

wernight commented Oct 11, 2016 •

edited

Loading