Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to honor PDB with an empty selector {} #119732

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix to honor PDB with an empty selector {} #119732

merged 1 commit into from
Aug 16, 2023

Conversation

sairameshv
Copy link
Member

@sairameshv sairameshv commented Aug 2, 2023 •
edited
Loading

PDB with an empty selector {} is selecting all the pods in a namespace. But, during the drain, all the pods are getting evicted which is not expected. This change should fix the issue and honor the pdb before evicting the pods.

What type of PR is this?

/kind bug

Which issue(s) this PR fixes:

Fixes #119731

Special notes for your reviewer:

Issue could be part of #95083 that was fixed by #99290
Somehow this change could have been missed and is on the similar lines as of this change

Does this PR introduce a user-facing change?

Fixed an issue to not drain all the pods in a namespace when an empty-selector i.e. "{}" is specified in a Pod Disruption Budget (PDB)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/85-Graduate-PDB-to-Stable

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Aug 2, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.28 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.28.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 2 10:20:21 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 2, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 2, 2023
@sairameshv sairameshv marked this pull request as ready for review August 2, 2023 15:41
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2023
@sairameshv
Copy link
Member Author

/retest

@sairameshv
Copy link
Member Author

/cc @liggitt

Hello Jordan, Could you PTAL at this change?

@k8s-ci-robot k8s-ci-robot requested a review from liggitt August 7, 2023 09:21
@liggitt
Copy link
Member

liggitt commented Aug 7, 2023

lgtm, this is consistent with PDB v1 documented behavior

this needs a test demonstrating the issue and the fix

@sairameshv
Fix to honor PDB with an empty selector {}
a6329ac 
PDB with an empty selector `{}` is selecting all the pods in a namespace.
But, during the `drain`, all the pods are getting evicted which is not expected.
This change should fix the issue and honor the pdb before evicting the pods.

Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2023
@liggitt
Copy link
Member

liggitt commented Aug 8, 2023

/sig apps
/lgtm
/approve
/milestone v1.29

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3bb2d2351a6f9aba90e7c12ec62bf699d8be9c27

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit fd4109d into kubernetes:master Aug 16, 2023
This was referenced Oct 11, 2023
Merged
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 11, 2023
k8s-ci-robot added a commit that referenced this pull request Oct 16, 2023
@k8s-ci-robot
Merge pull request #121131 from sairameshv/automated-cherry-pick-of-#…
c51dd23 
…119732-upstream-release-1.28

Automated cherry pick of #119732: Fix to honor PDB with an empty selector `{}`
k8s-ci-robot added a commit that referenced this pull request Oct 16, 2023
@k8s-ci-robot
Merge pull request #121132 from sairameshv/automated-cherry-pick-of-#…
7d415c6 
…119732-upstream-release-1.27

Automated cherry pick of #119732: Fix to honor PDB with an empty selector `{}`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

PodDisruptionBudget with an empty selector {} being honored incorrectly
3 participants
@sairameshv @k8s-ci-robot @liggitt