Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add servedVersions info in StorageVersion API #118386

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Add servedVersions info in StorageVersion API #118386

merged 1 commit into from
Jul 6, 2023

Conversation

richabanker
Copy link
Contributor

@richabanker richabanker commented Jun 2, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a new field ServedVersions to the StorageVersion API which is needed to look up API servers that can serve a GVR for the purpose of UVIP

Does this PR introduce a user-facing change?

Add ServedVersions field to StorageVersion API

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/4020-unknown-version-interoperability-proxy

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 2, 2023
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@richabanker richabanker changed the title Add servedVersions info in StorageVersion API [WIP] Add servedVersions info in StorageVersion API Jun 2, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2023
@alexzielenski
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 6, 2023
@richabanker richabanker force-pushed the enhance-storage-version branch 3 times, most recently from 5278ccb to 16a3362 Compare June 15, 2023 01:17
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 15, 2023
@richabanker richabanker force-pushed the enhance-storage-version branch from 16a3362 to 1c2d91f Compare June 15, 2023 02:50
@richabanker richabanker force-pushed the enhance-storage-version branch from fb6f74a to dde7adc Compare June 15, 2023 06:52
@richabanker richabanker force-pushed the enhance-storage-version branch from e598bbe to e2efc39 Compare June 28, 2023 22:12
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2023
@richabanker richabanker force-pushed the enhance-storage-version branch 2 times, most recently from 839bb16 to a014f47 Compare June 28, 2023 23:59
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 28, 2023
jiahuif
jiahuif reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@jiahuif jiahuif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc

api/api-rules/violation_exceptions.list Outdated Show resolved Hide resolved
staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested a review from jiahuif June 29, 2023 00:04
@richabanker richabanker force-pushed the enhance-storage-version branch 3 times, most recently from eb1f533 to 3cb6dd2 Compare June 29, 2023 19:29
@deads2k
Copy link
Contributor

deads2k commented Jun 29, 2023

/approve

squash for merge please.

@richabanker
Copy link
Contributor Author

/test pull-kubernetes-unit

@richabanker richabanker force-pushed the enhance-storage-version branch from 3c6886e to 1c48b7e Compare June 29, 2023 22:41
jiahuif
jiahuif approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@jiahuif jiahuif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4fcd42578419bc2a57bc9fd8716b31d4f4aef29

@jiahuif
Copy link
Member

jiahuif commented Jul 6, 2023

@roycaihw for approval coverage.
Thank you!

@roycaihw
Copy link
Member

roycaihw commented Jul 6, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jiahuif, Richabanker, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit cd32ade into kubernetes:master Jul 6, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 6, 2023
@richabanker richabanker mentioned this pull request Jul 7, 2023
Closed
@richabanker richabanker mentioned this pull request Jul 17, 2023
Open
12 tasks
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-chenzz charles-chenzz charles-chenzz left review comments

@deads2k deads2k deads2k left review comments

@roycaihw roycaihw roycaihw left review comments

@jiahuif jiahuif jiahuif approved these changes

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@jiahuif jiahuif

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
8 participants
@richabanker @k8s-triage-robot @alexzielenski @deads2k @k8s-ci-robot @jiahuif @roycaihw @charles-chenzz