Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support BackoffLimitPerIndex in Jobs #118009

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Support BackoffLimitPerIndex in Jobs #118009

merged 1 commit into from
Jul 18, 2023

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented May 15, 2023 •
edited
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:

Tracking Issue: kubernetes/enhancements#3850

Special notes for your reviewer:

The API changes are now extracted to a dedicated PR: #119294. Please leave you API review comments there.

Changes compared to KEP:

  1. The .spec.BackoffLimitPerIndex is immutable - the KEP says it just couldn't be unset. It can be as in KEP, but I thought the usefulness of mutability is low for this field, and so there is not need to complicate the validation code.
  2. The messages for the job failures are static without computing the set of failed indexes

Does this PR introduce a user-facing change?

Support BackoffLimitPerIndex in Jobs

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/3850-backoff-limits-per-index-for-indexed-jobs

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 15, 2023
@k8s-ci-robot k8s-ci-robot requested review from kow3ns and lavalamp May 15, 2023 09:04
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 15, 2023
@mimowo mimowo force-pushed the backoff-limit-per-index branch 2 times, most recently from d881b9e to c65f603 Compare May 15, 2023 09:30
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2023
@mimowo mimowo force-pushed the backoff-limit-per-index branch 3 times, most recently from d977233 to 475c6a3 Compare May 17, 2023 09:04
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2023
@mimowo mimowo changed the title WIP: Support backoff limit per index WIP: Support backoff limit per index (POC implementation) May 22, 2023
@mimowo mimowo force-pushed the backoff-limit-per-index branch 2 times, most recently from e7aa965 to 1b359d1 Compare May 24, 2023 13:56
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2023
@mimowo mimowo force-pushed the backoff-limit-per-index branch from 1b359d1 to d3bd9f6 Compare June 1, 2023 16:16
@k8s-ci-robot k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jun 1, 2023
alculquicondor
alculquicondor reviewed Jul 18, 2023
View reviewed changes
pkg/controller/job/indexed_job_utils.go Outdated Show resolved Hide resolved
pkg/controller/job/job_controller.go Outdated Show resolved Hide resolved
test/integration/job/job_test.go Outdated Show resolved Hide resolved
test/integration/job/job_test.go Outdated Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 831487351a7138a719a5bb314e8a85d83ed9de07

@alculquicondor
Copy link
Member

/hold
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Jul 18, 2023
@alculquicondor
Copy link
Member

/retest

@mimowo mimowo force-pushed the backoff-limit-per-index branch from f8ed283 to e9d3ad9 Compare July 18, 2023 17:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@mimowo mimowo force-pushed the backoff-limit-per-index branch from e9d3ad9 to 158f6c4 Compare July 18, 2023 17:16
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@alculquicondor
Copy link
Member

API is merged, can you rebase and squash?

@alculquicondor
Copy link
Member

oh, you did that already :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7edb5ecfa5d837de683cbb8bfd515e16f50b4a4a

@mimowo
Copy link
Contributor Author

mimowo commented Jul 18, 2023

@alculquicondor rebased to make sure there are no API changes in this PR, so that the robot picks up and reduce the modified directories to just job. Please renew LGTM.

@alculquicondor
Copy link
Member

/retest
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@alculquicondor alculquicondor mentioned this pull request Jul 18, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit a15c276 into kubernetes:master Jul 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 18, 2023
@liggitt liggitt removed the api-review Categorizes an issue or PR as actively needing an API review. label Aug 17, 2023
@mimowo mimowo mentioned this pull request Oct 19, 2023
Merged
6 tasks
@mimowo mimowo deleted the backoff-limit-per-index branch November 29, 2023 15:01
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@kannon92 kannon92 kannon92 left review comments

@kow3ns kow3ns Awaiting requested review from kow3ns

@lavalamp lavalamp Awaiting requested review from lavalamp

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
9 participants
@mimowo @k8s-ci-robot @alexzielenski @alculquicondor @kannon92 @k8s-triage-robot @jiahuif @deads2k @liggitt